Skip to content

test(aws-lambda-python): remove hard-coded references to @aws-cdk/aws-lambda#15994

Merged
mergify[bot] merged 1 commit intomasterfrom
njlynch/lambda-python-test
Aug 11, 2021
Merged

test(aws-lambda-python): remove hard-coded references to @aws-cdk/aws-lambda#15994
mergify[bot] merged 1 commit intomasterfrom
njlynch/lambda-python-test

Conversation

@njlynch
Copy link
Copy Markdown
Contributor

@njlynch njlynch commented Aug 11, 2021

Remove the hard coded reference to the @aws-cdk/aws-lambda packages from the
test, which should fix the issue that prevent building the package as an alpha module in v2.

This was previously done in #15921, but I missed these entries in the tests.

related #15586


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…-lambda

Remove the hard coded reference to the @aws-cdk/aws-lambda packages from the
test, which should fix the issue that prevent building the package as an alpha module in v2.

related #15586
@njlynch njlynch requested a review from otaviomacedo August 11, 2021 13:52
@njlynch njlynch self-assigned this Aug 11, 2021
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Aug 11, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 11, 2021
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: ffe6759
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e17c627 into master Aug 11, 2021
@mergify mergify bot deleted the njlynch/lambda-python-test branch August 11, 2021 14:37
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 11, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

njlynch added a commit that referenced this pull request Aug 11, 2021
Now that the hard-coded refernces to @aws-cdk/aws-lambda have been removed from
these packages, we can publish them as "normal" alpha modules. This just
involves removing the special config from both package.jsons.

Note this is also forward-porting #15994 from master, which was missed in the
original change to make these packages v2-compliant. We _could_ just wait for
the next forward merge job, but wanting to close this out while I still have
context.

closes #15586
closes #15585
mergify bot pushed a commit that referenced this pull request Aug 23, 2021
Remove the hard-coded refernces to @aws-cdk/aws-lambda from
these packages, and publish them as "normal" alpha modules. This just
involves removing the special config from both package.jsons.

Note this is also forward-porting #15994 from master, which was missed in the
original change to make these packages v2-compliant. We _could_ just wait for
the next forward merge job, but wanting to close this out while I still have
context.

closes #15586
closes #15585


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
…-lambda (aws#15994)

Remove the hard coded reference to the @aws-cdk/aws-lambda packages from the
test, which should fix the issue that prevent building the package as an alpha module in v2.

This was previously done in aws#15921, but I missed these entries in the tests.

related aws#15586

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
…-lambda (aws#15994)

Remove the hard coded reference to the @aws-cdk/aws-lambda packages from the
test, which should fix the issue that prevent building the package as an alpha module in v2.

This was previously done in aws#15921, but I missed these entries in the tests.

related aws#15586

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants