chore: fix alpha build of lambda-go/python packages#15995
Merged
mergify[bot] merged 2 commits intov2-mainfrom Aug 23, 2021
Merged
chore: fix alpha build of lambda-go/python packages#15995mergify[bot] merged 2 commits intov2-mainfrom
mergify[bot] merged 2 commits intov2-mainfrom
Conversation
Now that the hard-coded refernces to @aws-cdk/aws-lambda have been removed from these packages, we can publish them as "normal" alpha modules. This just involves removing the special config from both package.jsons. Note this is also forward-porting #15994 from master, which was missed in the original change to make these packages v2-compliant. We _could_ just wait for the next forward merge job, but wanting to close this out while I still have context. closes #15586 closes #15585
|
|
nija-at
approved these changes
Aug 23, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the hard-coded refernces to @aws-cdk/aws-lambda from
these packages, and publish them as "normal" alpha modules. This just
involves removing the special config from both package.jsons.
Note this is also forward-porting #15994 from master, which was missed in the
original change to make these packages v2-compliant. We could just wait for
the next forward merge job, but wanting to close this out while I still have
context.
closes #15586
closes #15585
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license