Skip to content

ci: codecov: use env vars instead of flags#2648

Merged
blueyed merged 1 commit intoawesomeWM:masterfrom
blueyed:codecov-remove-flags
Feb 14, 2019
Merged

ci: codecov: use env vars instead of flags#2648
blueyed merged 1 commit intoawesomeWM:masterfrom
blueyed:codecov-remove-flags

Conversation

@blueyed
Copy link
Copy Markdown
Member

@blueyed blueyed commented Feb 14, 2019

Using flags appears to trigger timeouts with codecov's backend.
This uses env variables instead.

@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Feb 14, 2019

Might make sense to keep flags for "c_code" and "lua" (just two then), but let's see how this behaves with envs only for now here.

@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Feb 14, 2019

There are two Travis CI jobs here?! /cc @Elv13

@Elv13
Copy link
Copy Markdown
Member

Elv13 commented Feb 14, 2019

No idea why, first time I see it

@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Feb 14, 2019

Yeah, also not with the last PRs.. weird.
Links for future reference:

  1. https://github.com/awesomeWM/awesome/pull/2648/checks?check_run_id=63519202
  2. https://github.com/awesomeWM/awesome/pull/2648/checks?check_run_id=63519191

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 14, 2019 •
edited
Loading

Codecov Report

Merging #2648 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2648      +/-   ##
==========================================
- Coverage   85.32%   85.31%   -0.02%     
==========================================
  Files         519      519              
  Lines       35182    35182              
==========================================
- Hits        30018    30014       -4     
- Misses       5164     5168       +4
Flag Coverage Δ
#c_code ?
#functionaltests ?
#lua53 ?
#samples ?
#themes ?
#unittests ?
Impacted Files Coverage Δ
xwindow.c 92.39% <0%> (-0.55%) ⬇️
property.c 80.18% <0%> (-0.48%) ⬇️
objects/client.c 79.1% <0%> (-0.16%) ⬇️

@Elv13
Copy link
Copy Markdown
Member

Elv13 commented Feb 14, 2019 •
edited
Loading

It no longer timeout! ... but the coverage regressed (at least until it gets updated?)

edit: It got updated

@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Feb 14, 2019

Not finished yet.
There is just one PR build queued at https://travis-ci.com/awesomeWM/awesome/pull_requests - https://travis-ci.com/awesomeWM/awesome/builds/100949859.

@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Feb 14, 2019

Both "checks" link to the same build.

@Elv13
Copy link
Copy Markdown
Member

Elv13 commented Feb 14, 2019 •
edited
Loading

It's still strange there's 2 Travis builds. Even the previous PRs a couple hours ago didn't exhibit this issue.

#2646

Probably a race condition on their builder load balancer or we triggered the build during an update rollout.

@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Feb 14, 2019

A lot of "new files" at https://codecov.io/gh/awesomeWM/awesome/pull/2648/tree currently.

@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Feb 14, 2019

"New file" appears to be a bug / UI issue with codecov?! Looks like in master.. list style: https://codecov.io/gh/awesomeWM/awesome/pull/2648/list/

@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Feb 14, 2019

But the second Travis check appears to be stuck now - linked build finished, but it is still in "created" state.

@blueyed blueyed closed this Feb 14, 2019
@blueyed blueyed reopened this Feb 14, 2019
@blueyed blueyed closed this Feb 14, 2019
@blueyed blueyed reopened this Feb 14, 2019
@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Feb 14, 2019

Also happened with a new PR: #2649

This was referenced Feb 14, 2019
Closed
Closed
@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Feb 14, 2019

Not happening here: #2650

Related to changing .travis.yml?!

blueyed added a commit to blueyed/awesome that referenced this pull request Feb 14, 2019
@blueyed
travis.yml: same as with awesomeWM#2648
c16de54
@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Feb 14, 2019 •
edited
Loading

Weird.. could not reproduce it in #2650, with the same changes in the end, but only once.

@blueyed
ci: codecov: use env vars instead of flags
548c3df 
Using flags appears to trigger timeouts with codecov's backend.
This uses env variables instead.
@blueyed blueyed force-pushed the codecov-remove-flags branch from eece46f to 548c3df Compare February 14, 2019 15:54
@Elv13
Copy link
Copy Markdown
Member

Elv13 commented Feb 14, 2019

Weird.. could not reproduce it in #2650, with the same changes in the end.

Lets wait a couple days and if it persist, open an issue. Their support team is usually very good. There is a lot of "maybe" here. In any case, it isn't really a big issue.

@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Feb 14, 2019

Ok. Fixed after force-pushing.

Elv13
Elv13 approved these changes Feb 14, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@Elv13 Elv13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge this and see if the "new file" issue persist. Having CodeCov back is already a big deal.

@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Feb 14, 2019

coveralls is missing still?

@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Feb 14, 2019

Maybe it got confused by the re-opening etc, merging.

@blueyed blueyed merged commit df9ed76 into awesomeWM:master Feb 14, 2019
@blueyed blueyed deleted the codecov-remove-flags branch February 14, 2019 16:18
@Elv13
Copy link
Copy Markdown
Member

Elv13 commented Feb 14, 2019

👍

@blueyed blueyed mentioned this pull request Feb 14, 2019
Merged
petoju pushed a commit to petoju/awesome that referenced this pull request Jun 8, 2019
@blueyed @petoju
ci: codecov: use env vars instead of flags (awesomeWM#2648)
e977fde 
Using flags appears to trigger timeouts with codecov's backend.
This uses env variables instead.
actionless pushed a commit to actionless/awesome that referenced this pull request Mar 24, 2021
@blueyed @actionless
ci: codecov: use env vars instead of flags (awesomeWM#2648)
9a307ff 
Using flags appears to trigger timeouts with codecov's backend.
This uses env variables instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Elv13 Elv13 Elv13 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blueyed @Elv13