Fix a CMake warning when GENERATE_DOC is off#2646
Closed
psychon wants to merge 1 commit intoawesomeWM:masterfrom
Closed
Fix a CMake warning when GENERATE_DOC is off#2646psychon wants to merge 1 commit intoawesomeWM:masterfrom
psychon wants to merge 1 commit intoawesomeWM:masterfrom
Conversation
This fixes the following CMake warning that I saw in some NixOS build: CMake Warning (dev) at CMakeLists.txt:457 (add_dependencies): Policy CMP0046 is not set: Error on non-existent dependency in add_dependencies. Run "cmake --help-policy CMP0046" for policy details. Use the cmake_policy command to set the policy and suppress this warning. The dependency target "check-examples" of target "check" does not exist. This warning is for project developers. Use -Wno-dev to suppress it. Signed-off-by: Uli Schlachter <psychon@znc.in>
Codecov Report
@@ Coverage Diff @@
## master #2646 +/- ##
==========================================
+ Coverage 85.3% 85.31% +<.01%
==========================================
Files 519 519
Lines 35181 35181
==========================================
+ Hits 30012 30015 +3
+ Misses 5169 5166 -3
|
blueyed
previously approved these changes
Feb 14, 2019
Member
|
Note that the include of |
See previous comment, finishing #2545 might be better, I am +0 on this.
blueyed
approved these changes
Feb 18, 2019
Member
|
Since #2545 has been merged this should not be necessary anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following CMake warning that I saw in some NixOS build:
CMake Warning (dev) at CMakeLists.txt:457 (add_dependencies):
Policy CMP0046 is not set: Error on non-existent dependency in
add_dependencies. Run "cmake --help-policy CMP0046" for policy details.
Use the cmake_policy command to set the policy and suppress this warning.
The dependency target "check-examples" of target "check" does not exist.
This warning is for project developers. Use -Wno-dev to suppress it.
Signed-off-by: Uli Schlachter psychon@znc.in