Conversation
Codecov Report
@@ Coverage Diff @@
## master #1993 +/- ##
==========================================
+ Coverage 84.57% 84.66% +0.08%
==========================================
Files 497 497
Lines 33729 33750 +21
==========================================
+ Hits 28526 28574 +48
+ Misses 5203 5176 -27
|
02466b4 to
4e7d25a
Compare
|
|
||
| # Run gcov. Upload for codecov directly, gets done later for coveralls. | ||
| # NOTE: files for the main target have the build dir as prefix, but | ||
| # otherwise it is the source directory?! |
There was a problem hiding this comment.
Any idea about this?
Is it relevant where the binary is run from?
Probably rather where it is built from?!
There was a problem hiding this comment.
I'm not really sure what this comment means. What is "otherwise"? Which files is this about?
According to https://gcc.gnu.org/onlinedocs/gcc-4.7.3/gcc/Gcov-Data-Files.html#Gcov-Data-Files, the same directory as the object file is used, so build dir. However, I guess that if the compiler is invoked with a relative path, then the program ends up using a relative path as well...? I'm not really sure since I don't fully grasp what the "symptoms" are.
On an unrelated note: You recently opened quite a number of PRs and it felt to me that some of them were still WIP, so I ignored them. If you feel like some PR is "finally done", I would suggest to add a comment saying so, so that everyone knows about it. I'm mostly working based on GitHub notifications and so for me PRs can easily "fall through the cracks".
There was a problem hiding this comment.
the same directory as the object file is used, so build dir. However, I guess that if the compiler is invoked with a relative path, then the program ends up using a relative path as well...?
The object files in build//CMakeFiles/awesome.dir seem to have build/ prefix, while the files in build//CMakeFiles/{lgi-check.dir,test-gravity.dir} do not have it.
I'm mostly working based on GitHub notifications and so for me PRs can easily "fall through the cracks".
I see. I'll request your review in case it takes to long.
Also, I will make sure to add WIP preffixed more often.
There was a problem hiding this comment.
lgi-check is created via add_executable(lgi-check build-utils/lgi-check.c), i.e. a source-relative path. Instead, for the awesome executable we use absolute paths to the pre-processed .c files in the build dir (so relative to the source dir this means: there is an additional build/ prefix).
Also: Thanks :-)
3eb739e to
737a297
Compare
|
Integrating into #2672. |
Taken out of #1907, to see how it behaves on master.
https://github.com/eddyxu/cpp-coveralls
https://github.com/moteus/luacov-coveralls#test-lua-module-written-on-lua-and-c-using-cpp-coveralls
TODO: