Skip to content

Add coverage reporting to more jobs#2672

Open
blueyed wants to merge 1 commit intoawesomeWM:masterfrom
blueyed:more-coverage
Open

Add coverage reporting to more jobs#2672
blueyed wants to merge 1 commit intoawesomeWM:masterfrom
blueyed:more-coverage

Conversation

@blueyed
Copy link
Copy Markdown
Member

@blueyed blueyed commented Feb 18, 2019 •
edited
Loading

TODO:

This was referenced Feb 18, 2019
Closed
Merged
@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Feb 18, 2019

Pulled out BUILD_IN_DIR related commits/changes for now.

@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Feb 18, 2019

coverage/coveralls — Coverage decreased (-3.4%) to 85.567%

Expected due to new gcov/C coverage.

@blueyed blueyed changed the title [WIP] add coverage reporting to more jobs [RFC] add coverage reporting to more jobs Feb 19, 2019
@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Feb 19, 2019

Ready for review.

@psychon
Copy link
Copy Markdown
Member

psychon commented Feb 19, 2019

I didn't look at the individual commits.

So... why?

  • This adds coverage reporting to more jobs, as mentioned in the title. I haven't seen a reason why this is done.
  • This moves coverage reporting to the end of the build and gets rid of the "intermediate reports".
  • This moves some stuff to a helper script.

These are the "big changes" that I saw. The last two can be considered cleanup and the first one will allow to get some more code covered that is specific to Lua versions, I guess...

@blueyed blueyed mentioned this pull request Feb 19, 2019
Closed
@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Feb 19, 2019

@psychon
Correct.

For 1.: I think covering more variants is good in general, and especially to use the same ones when reporting them to coveralls/codecov (to ensure they have the same data base).

It looks like this might trigger #2675 though.

@awesomeWM awesomeWM deleted a comment from codecov bot Feb 19, 2019
@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Feb 19, 2019

coveralls has no references to C code in build anymore.
But to build/themes via luacov, but also on master.

@blueyed blueyed added enhancement ci:skip_prev_commits Used on Travis to skip tests for previous commits labels Feb 19, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 19, 2019 •
edited
Loading

Codecov Report

Merging #2672 into master will increase coverage by 0.1%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #2672     +/-   ##
========================================
+ Coverage    86.5%   86.6%   +0.1%     
========================================
  Files         569     569             
  Lines       38076   38294    +218     
========================================
+ Hits        32937   33164    +227     
+ Misses       5139    5130      -9
Flag Coverage Δ
#gcov 86.6% <ø> (+11.62%) ⬆️
#luacov 89.51% <ø> (+0.11%) ⬆️
Impacted Files Coverage Δ
luaa.c 66.4% <0%> (-3.16%) ⬇️
lib/awful/mouse/init.lua 59.11% <0%> (-0.12%) ⬇️
...amples/wibox/container/radialprogressbar/value.lua 100% <0%> (ø) ⬆️
tests/test-tooltip.lua 100% <0%> (ø) ⬆️
tests/examples/awful/popup/position2.lua 100% <0%> (ø) ⬆️
...ts/examples/wibox/widget/separator/orientation.lua 100% <0%> (ø) ⬆️
tests/examples/wibox/widget/defaults/checkbox.lua 100% <0%> (ø) ⬆️
tests/test-awful-widget-button.lua 100% <0%> (ø) ⬆️
...ts/examples/wibox/container/arcchart/thickness.lua 100% <0%> (ø) ⬆️
common/luaobject.h 100% <0%> (ø) ⬆️
... and 114 more

@blueyed blueyed mentioned this pull request Feb 22, 2019
Open
@blueyed blueyed requested review from Elv13 and psychon February 22, 2019 04:39
psychon
psychon previously approved these changes Feb 22, 2019
View reviewed changes
@blueyed blueyed removed the ci:skip_prev_commits Used on Travis to skip tests for previous commits label Feb 23, 2019
@blueyed blueyed changed the title [RFC] add coverage reporting to more jobs Add coverage reporting to more jobs Feb 23, 2019
@blueyed blueyed closed this Feb 23, 2019
@blueyed blueyed reopened this Feb 23, 2019
@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Feb 24, 2019

codecov/patch Expected — Waiting for status to be reported

Still after close / re-open..

@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Feb 24, 2019 •
edited
Loading

https://codecov.io/github/awesomeWM/awesome/commit/b90a516225d3e294334f6871bae212171b20225b says:

There was an error processing coverage reports.
Most common issues
File paths are not resolving. Reports are empty or do not contain your files. Report has expired.

Re-trying.

@blueyed blueyed force-pushed the more-coverage branch 3 times, most recently from 278c6c2 to e5b034e Compare March 3, 2019 22:14
@blueyed blueyed changed the title Add coverage reporting to more jobs [WIP] Add coverage reporting to more jobs Mar 3, 2019
@blueyed blueyed changed the title [WIP] Add coverage reporting to more jobs Add coverage reporting to more jobs Mar 24, 2019
@blueyed blueyed mentioned this pull request Mar 24, 2019
Open
@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Mar 24, 2019

Could use lcoveralls with lcov maybe: https://github.com/universal-ctags/ctags/blob/92a2c04b5e27a6850e429ee888553a40eb78ff19/.travis.yml#L53-L67

@blueyed
Travis: use DO_COVERAGE=1 for both Codecov and Coveralls
8a2c714 
* Move coverage reporting to after_success

  This likely prevents Codecov from posting comment(s) too early (and not
  updating them), and is likely needed for Coveralls.

* coverage for luajit

* Skipping lua5.1 with BUILD_IN_DIR for now.

* Integrate cpp-coveralls

* Move gcov processing to separate file
@blueyed blueyed mentioned this pull request Jun 15, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@psychon psychon psychon left review comments

@Elv13 Elv13 Awaiting requested review from Elv13

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blueyed @psychon