Skip to content

[WIP] Code Climate integration#2564

Open
blueyed wants to merge 12 commits intoawesomeWM:masterfrom
blueyed:codeclimate
Open

[WIP] Code Climate integration#2564
blueyed wants to merge 12 commits intoawesomeWM:masterfrom
blueyed:codeclimate

Conversation

@blueyed
Copy link
Copy Markdown
Member

@blueyed blueyed commented Jan 9, 2019

@actionless
Copy link
Copy Markdown
Member

and wht's the main difference between codecov and code climate?

@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Jan 9, 2019

I want to evaluate alternatives to Codecov, which is not really usable as of lately (since weeks/months) due to report pages timing out.
Contacted support about this already, but they are not reacting to it really.

@actionless
Copy link
Copy Markdown
Member

i see, thanks for explaining!

@blueyed blueyed changed the title Code Climate integration [WIP] Code Climate integration Jan 10, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 10, 2019

Codecov Report

Merging #2564 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2564      +/-   ##
==========================================
- Coverage   84.65%   84.64%   -0.01%     
==========================================
  Files         496      496              
  Lines       33738    33738              
==========================================
- Hits        28562    28559       -3     
- Misses       5176     5179       +3
Flag Coverage Δ
#c_code 73.49% <ø> (-0.05%) ⬇️
#functionaltests 70.96% <ø> (ø) ⬆️
#lua53 84.64% <ø> (-0.01%) ⬇️
#samples 74.65% <ø> (ø) ⬆️
#themes 49.77% <ø> (ø) ⬆️
#unittests 58.17% <ø> (ø) ⬆️
Impacted Files Coverage Δ
event.c 71.2% <0%> (-0.9%) ⬇️
property.c 80% <0%> (+0.46%) ⬆️

@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Jan 10, 2019

Hmm, getting "Invalid path part" again:

{
  "message": "Invalid path part \"\"",
  "file_document": "{\"_id\"=>BSON::ObjectId('5c372e1cf4e4681a5700432f'), \"type\"=>\"test_file_reports\", \"blob_id\"=>\"c0e3bfcd2a36850f1c88a54b2722586e2b8d4d30\", \"coverage\"=>\"[null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,5,null,5,5,5,5,5,null,0,null,0,null,null,null,null,0,0,null,5,5,null,null,null]\", \"covered_percent\"=>66.66666666666666, \"covered_strength\"=>3.3333333333333335, \"line_counts\"=>{\"missed\"=>4, \"covered\"=>8, \"total\"=>12}, \"path\"=>\"/home/travis/build/awesomeWM/awesome/build-utils/lgi-check.c\", \"test_report_id\"=>BSON::ObjectId('5c372e1b8775fe559e004011')}"
}

(https://codeclimate.com/repos/5c35e985236f14026e00ceb2/settings/test_reports/5c372e1b8775fe559e004011)

@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Jan 10, 2019

Code Climate coverage upload worked: https://codeclimate.com/repos/5c35e985236f14026e00ceb2/settings/test_reports/5c373baff06c884152004fdd.

Uploading .gcov files per gcov run also improves Codecov! Maybe fixes the flakyness there?!

@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Jan 10, 2019

Installed Code Climate PR comments and status updates. Maybe/likely we want to keep only the status updates, but let's see.

@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Jan 10, 2019

Oh, Codecov needs to be fixed - likely to doing this from build/ now.

@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Jan 10, 2019

Well, gcov processing was broken completely.

@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Jan 10, 2019

I bet this (uploading per gcov run per file) helps with the flaky coverage we're seeing with codecov.

@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Jan 10, 2019

Code Climate error is state=error, but without a reason: https://codeclimate.com/repos/5c35e985236f14026e00ceb2/settings/test_reports/5c37665e8775fe7dbf007723
Contacted support about it.

@blueyed blueyed mentioned this pull request Jan 10, 2019
2 tasks
@psychon
Copy link
Copy Markdown
Member

psychon commented Jan 11, 2019

@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Jan 11, 2019

@psychon
Yeah, one/some of them, but not the latest: https://codeclimate.com/repos/5c35e985236f14026e00ceb2/settings/test_reporter

@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Jan 11, 2019

@blueyed
Copy link
Copy Markdown
Member Author

blueyed commented Jan 11, 2019

But it looks like C coverage is still flaky (via Codecov) (after #2574) - maybe it just got better, but not yet fixed?!

Impacted Files	Coverage Δ	
event.c	71.2% <0%> (-0.9%)	
property.c	80% <0%> (+0.46%)	

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants