veri: replace TestResult::MultiType with callback#85
Closed
mmcloughlin wants to merge 1 commit intoverify-mainfrom
Closed
veri: replace TestResult::MultiType with callback#85mmcloughlin wants to merge 1 commit intoverify-mainfrom
TestResult::MultiType with callback#85mmcloughlin wants to merge 1 commit intoverify-mainfrom
Conversation
TestResult::MultiType with callback
Collaborator
Author
|
Replaced by #86. |
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Oct 9, 2024
Implements `match` expression for pattern matching on enum values. Updates avanhatt#48
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Oct 9, 2024
Refactor `isaspec` builder to introduce explicit types for case splitting. This PR is a no-op for the generated specs, but it is intended to enable a future change to support splitting over enum `match` statements (recently added in avanhatt#85). The `substitute` function is also moved to the `isaspec::spec` module, alongside other helpers for manipulating spec ASTs. Updates avanhatt#48
avanhatt
pushed a commit
that referenced
this pull request
Jan 11, 2026
Expand "wiz" to "wizen" in test function name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the
TestResult::MultiTypevariant with a callback thatcomputes the expected
VerificationResultfor a providedTermSignature.The
MultiTypevariant was only used in a single test, where it was used toprovide a list of expectations derived from
isle_inst_types().wasmtime/cranelift/isle/veri/veri_engine/tests/veri.rs
Lines 1102 to 1126 in 575c137
The motivation for this change is that this approach will no longer work
if we provide ISLE term signatures in the source code instead, as implemented
in #82. The term signatures will only be known later, at which point we can
use the
TestResult::Expectcallback to derive the expectation.