veri: term signature instantiations in ISLE#82
Merged
mmcloughlin merged 20 commits intoverify-mainfrom Nov 29, 2023
Merged
Conversation
740d574 to
ee27771
Compare
avanhatt
reviewed
Nov 29, 2023
avanhatt
approved these changes
Nov 29, 2023
Owner
avanhatt
left a comment
There was a problem hiding this comment.
This new syntax is much nicer!
mmcloughlin
added a commit
that referenced
this pull request
Nov 29, 2023
This PR replaces the `TestResult::MultiType` variant with a callback that computes the expected `VerificationResult` for a provided `TermSignature`. The `MultiType` variant was only used in a single test, where it was used to provide a list of expectations derived from `isle_inst_types()`. https://github.com/avanhatt/wasmtime/blob/575c137da4f90601f6542775ed40420d6524f5d0/cranelift/isle/veri/veri_engine/tests/veri.rs#L1102-L1126 The motivation for this change is that this approach will no longer work if we provide ISLE term signatures in the source code instead, as implemented in #82. The term signatures will only be known later, at which point we can use the `TestResult::Expect` callback to derive the expectation.
1e9404b to
cea8544
Compare
Also, rename "signatures" to "form".
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Oct 9, 2024
Trigger ASLp CI workflow on PRs that change `isaspec` crate.
avanhatt
pushed a commit
that referenced
this pull request
Jan 11, 2026
Re-export Wasmtime crate to allow easier use with Wizer API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces
isle_inst_typeshardcoded type signatures inwidths.rswith ISLE syntax for term instantiations.
Signatures may now be specified with the
instantiatedefinition, forexample:
Common sets of signatures can be specified with a
formdefinition andreused by name, for example: