Skip to content

Releasing refs/heads/release/2.1.0 into master#1039

Merged
romaninsh merged 2926 commits intomasterfrom
release/2.1.0
Mar 30, 2020
Merged

Releasing refs/heads/release/2.1.0 into master#1039
romaninsh merged 2926 commits intomasterfrom
release/2.1.0

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Mar 30, 2020

  • Review changes (must include stable dependencies)
  • Merge this PR into master (will delete refs/heads/release/2.1.0)
  • Go to Releases and create TAG from master
    Do not merge master into develop

mvorisek and others added 17 commits March 21, 2020 23:15
* Add CS fixer dev dependency

* Add concat spaces

CS Fixer rule: {"concat_space": {"spacing": "one"}}
* [fix] PHP Notice Bad Index on jsCallback

Refactor getJsExec in jsCallabkack method.
- Returning a View is not dependant of index[0] anymore when in array.

Fix: #1010

* add comment

* more refactoring

* enable output of modal

* update demo

* Move return types to the code

* Fix StyleCI

* Use instanceof positively for better refactorability

* fix selenium test

* fix lookup and vue test

* Add missing end NL

Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz>
* Do not append semicolon to statement when not needed

* also if ends with block
* Feature/Dropdown Cascade Form Field

* missing return

* styleci

* add doc and connect to renderRow callback
* Fix TableColumn\Label for null values

When $field->get() returns null cast to empry Array to avoid foreach error.

* Update Labels.php

Co-authored-by: Imants Horsts <DarkSide666@users.noreply.github.com>
…1034)

This fix will prevent throwing an error about onDelete or onUpload callback not been set when running within another callback.

Fix: #1029
* [refactor] AutoComplete into Lookup

* setup proper file name for test

* update php doc reference

* Fix StyleCI

* fix test

* Apply fixes from StyleCI (#1032)

Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz>
Co-authored-by: Romans Malinovskis <me@nearly.guru>
Error in line 550 on 'Actions' column.
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@a59a910). Click here to learn what that means.
The diff coverage is 18.96%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1039   +/-   ##
=========================================
  Coverage          ?   24.86%           
  Complexity        ?     2655           
=========================================
  Files             ?      126           
  Lines             ?     6177           
  Branches          ?        0           
=========================================
  Hits              ?     1536           
  Misses            ?     4641           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
src/TableColumn/Password.php 100% <ø> (ø) 1 <0> (?)
src/ProgressBar.php 0% <ø> (ø) 4 <0> (?)
src/jsSearch.php 0% <ø> (ø) 5 <0> (?)
src/TableColumn/FilterModel/TypeDate.php 0% <0%> (ø) 14 <0> (?)
src/TableColumn/FilterModel/TypeString.php 0% <0%> (ø) 8 <0> (?)
src/FormField/TreeItemSelector.php 0% <0%> (ø) 13 <2> (?)
src/Card.php 0% <0%> (ø) 60 <1> (?)
src/Persistence/UI.php 41.97% <0%> (ø) 43 <0> (?)
src/Lister.php 58.62% <0%> (ø) 23 <0> (?)
src/Layout/Admin.php 0% <0%> (ø) 8 <0> (?)
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a59a910...381b7a1. Read the comment docs.

romaninsh and others added 8 commits March 30, 2020 22:48
* bump fomantic verison

* Update App.php
* Added working Dockerfile

* add codefresh build

* fix

* wip

* added helm

* wip

* add lock file for easier install

* wip

* wip

* wip

* wip

* wip

* wip
* Improving tutorials

* fix

* Apply fixes from StyleCI

* can update demo, that's also OK

* wip

* Apply fixes from StyleCI

* that's not a useful file

* cleaned up Actions menu and added more explanations

* not sure why tthis wasn't loading

* Apply fixes from StyleCI
@romaninsh romaninsh merged commit 3fdbd86 into master Mar 30, 2020
@romaninsh romaninsh deleted the release/2.1.0 branch March 30, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.