Skip to content

Feature/column user actions#832

Merged
ibelar merged 12 commits intodevelopfrom
feature/column-user-actions
Nov 4, 2019
Merged

Feature/column user actions#832
ibelar merged 12 commits intodevelopfrom
feature/column-user-actions

Conversation

@romaninsh
Copy link
Copy Markdown
Member

@romaninsh romaninsh commented Oct 30, 2019

Now grid's addAction supports a single-argument form and you can pass name of the action or UserAction object from the model.

This will add a button triggering the action using our brand new action executor!

$grid->addAction('test');

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 30, 2019 •
edited
Loading

Codecov Report

Merging #832 into develop will decrease coverage by 0.65%.
The diff coverage is 80.95%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #832      +/-   ##
=============================================
- Coverage         74%   73.34%   -0.66%     
- Complexity      2449     2477      +28     
=============================================
  Files            123      124       +1     
  Lines           5801     5831      +30     
=============================================
- Hits            4293     4277      -16     
- Misses          1508     1554      +46
Impacted Files Coverage Δ Complexity Δ
src/TableColumn/Actions.php 94.87% <100%> (+0.58%) 16 <6> (+2) ⬆️
src/Grid.php 76.4% <100%> (ø) 70 <2> (ø) ⬇️
src/Card.php 77.47% <100%> (ø) 53 <0> (ø) ⬇️
src/ActionExecutor/jsUserAction.php 75.86% <75.86%> (ø) 25 <25> (?)
src/View.php 87.04% <80%> (-0.11%) 156 <0> (+1)
src/ActionExecutor/jsEvent.php 0% <0%> (-90.7%) 23% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7027094...3dffab3. Read the comment docs.

ibelar and others added 6 commits October 31, 2019 13:47
@ibelar
update
dac611c 
- Create new Class jsUserAction based on existing jsCallback
- remove jsEvent executor from demos
- set demos using new jsUserAction
- update View method to use new jsUserAction
@romaninsh @StyleCIBot
Apply fixes from StyleCI
11aa37c
@ibelar
Code review
fc74c78 
Add comments
clean up.
@romaninsh @StyleCIBot
Apply fixes from StyleCI
3a9d8fd
@ibelar
update comment
f70380b
@ibelar
Merge branch 'feature/column-user-actions' of https://github.com/atk4/ui
5414861 
 into feature/column-user-actions
@romaninsh
Copy link
Copy Markdown
Member Author

romaninsh commented Nov 1, 2019 •
edited
Loading

@ibelar - can you check why tests fail? and after we can merge and focus on

  • MenuActions column decorator
  • CRUD.

Veeeery close now!

@ibelar
Copy link
Copy Markdown
Contributor

ibelar commented Nov 1, 2019

@romaninsh - test is fix and ready to merge.

@ibelar ibelar merged commit e6f1909 into develop Nov 4, 2019
@ibelar ibelar deleted the feature/column-user-actions branch November 4, 2019 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ibelar ibelar ibelar approved these changes

Assignees

@ibelar ibelar

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@romaninsh @ibelar