Skip to content

Feature/Table Menu Action#833

Merged
romaninsh merged 16 commits intodevelopfrom
feature/table-menu-action
Nov 7, 2019
Merged

Feature/Table Menu Action#833
romaninsh merged 16 commits intodevelopfrom
feature/table-menu-action

Conversation

@ibelar
Copy link
Copy Markdown
Contributor

@ibelar ibelar commented Nov 4, 2019

Implementation of Dropdown menu item in table.

$g = $app->add(['Grid']);
$g->setModel(new $Country($db));
$g->addActionMenuItem('edit'); // will add model edit action as a menu item
$g->addActionMenuItem('test', new jsExpression('console.log("testing")));

see demos/jsactionsgrid.php for usage with model action.

Screen Shot 2019-11-04 at 12 14 15 PM

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 4, 2019 •
edited
Loading

Codecov Report

Merging #833 into develop will increase coverage by <.01%.
The diff coverage is 77.55%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #833      +/-   ##
=============================================
+ Coverage      73.34%   73.35%   +<.01%     
- Complexity      2477     2514      +37     
=============================================
  Files            124      125       +1     
  Lines           5831     5919      +88     
=============================================
+ Hits            4277     4342      +65     
- Misses          1554     1577      +23
Impacted Files Coverage Δ Complexity Δ
src/View.php 87.29% <100%> (+0.25%) 159 <0> (+3) ⬆️
src/Grid.php 73.71% <57.14%> (-2.7%) 79 <11> (+9)
src/TableColumn/Actions.php 80.39% <58.82%> (-14.48%) 22 <12> (+6)
src/TableColumn/ActionMenu.php 88.67% <88.67%> (ø) 19 <19> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6f1909...5ced3dc. Read the comment docs.

ibelar and others added 5 commits November 4, 2019 14:28
@ibelar
update View::on()
a2d68b9 
Add ability to setup apiConfig for jsCallback.
@ibelar
updated
10a0907 
Fix dropdown when place inside a column table.
@romaninsh @StyleCIBot
Apply fixes from StyleCI
845ffd8
@ibelar
fix typo
53275c1
@ibelar
update method name
9f1c0c6
romaninsh
romaninsh approved these changes Nov 7, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@romaninsh romaninsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romaninsh romaninsh merged commit 5661df4 into develop Nov 7, 2019
@romaninsh romaninsh deleted the feature/table-menu-action branch November 7, 2019 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romaninsh romaninsh romaninsh approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ibelar @romaninsh