ci: fix release workflow step that is responsible for handling twitter#209
Merged
derberg merged 2 commits intoasyncapi:masterfrom Dec 8, 2020
derberg:fix-twitter
Merged
ci: fix release workflow step that is responsible for handling twitter#209derberg merged 2 commits intoasyncapi:masterfrom derberg:fix-twitter
derberg merged 2 commits intoasyncapi:masterfrom
derberg:fix-twitter
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
jonastg
added a commit
to jonastg/parser-js
that referenced
this pull request
Jan 18, 2021
* master: (24 commits) chore: Refactored code location for iterators (asyncapi#225) chore(release): 1.3.1 (asyncapi#222) fix: apply traits to standalone messages from components section (asyncapi#214) test: improve feedback loop from browser tests (asyncapi#216) ci: fix the space-issue in bump workflow (asyncapi#218) ci: update global workflows (asyncapi#217) chore(deps): bump ini from 1.3.5 to 1.3.7 (asyncapi#215) ci: rename pr testing job name and test node 14 (asyncapi#213) ci: bump workflow to start on push instead of release (asyncapi#212) chore(release): 1.3.0 (asyncapi#211) feat: add a traverse schema function (asyncapi#198) ci: add workflow that bumps parser in other asyncapi repos (asyncapi#208) ci: fix release workflow step that is responsible for handling twitter (asyncapi#209) ci: update global workflows (asyncapi#206) ci: disable any testing on draft PR (asyncapi#204) chore(release): 1.2.0 (asyncapi#202) feat: extend the components and asyncapi model with has-like functions (asyncapi#192) chore(deps-dev): bump semantic-release from 17.0.6 to 17.2.3 (asyncapi#199) chore(release): 1.1.1 (asyncapi#197) fix: channels with name '/' fail on validation (asyncapi#196) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since we introduced a step that validates what type of release we have (patch/minor/major) we have a problem with twitter step. It is not run when we do release, and instead, it runs next time we do the push, push commit with pump in package.json. As a result, in tweet, instead of putting the name of the user that is responsible for major/minor release, we put the name of the user that pushed bump commit, always bot user.
This PR should fix it by checking the version from package.json on master against the version from package.json available in the workflow. Taken from https://github.com/EndBug/version-check#static-checking-with-your-latest-version-on-npm