Skip to content

ci: add workflow that bumps parser in other asyncapi repos#208

Merged
derberg merged 1 commit intoasyncapi:masterfrom
derberg:add-automated-bump
Dec 10, 2020
Merged

ci: add workflow that bumps parser in other asyncapi repos#208
derberg merged 1 commit intoasyncapi:masterfrom
derberg:add-automated-bump

Conversation

@derberg
Copy link
Member

@derberg derberg commented Dec 4, 2020 •
edited
Loading

Description

So far just review and let me know what you think. In my opinion we should not merge it until we first make sure that dependants have workflows that test PRs and these workflows are required. Agreed?

  • action that is used here https://github.com/marketplace/actions/organization-projects-dependency-manager
  • it was tested against this repo, with this workflow. Result is here
  • looking at this search result, this workflow will bump parser in:
    • asyncapi/nodejs-ws-template as fix:
    • asyncapi/playground as fix:
    • asyncapi/raml-dt-schema-parser as chore:
    • asyncapi/openapi-schema-parser as chore:
    • asyncapi/avro-schema-parser as chore:
    • asyncapi/asyncapi-react as fix:
    • asyncapi/html-template as chore:
    • asyncapi/tck as fix:
    • asyncapi/generator as fix:
    • asyncapi/template-for-generator-templates as chore:

Related issue(s)
See also asyncapi/.github#16

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg derberg requested a review from fmvilas December 7, 2020 11:55
fmvilas
fmvilas approved these changes Dec 7, 2020
View reviewed changes
This was referenced Dec 8, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@derberg
Copy link
Member Author

derberg commented Dec 9, 2020

No need to setup PR testing for below as there are no tests:

  • asyncapi/nodejs-ws-template
  • asyncapi/playground
  • asyncapi/tck

PR testing created in below repos. It is mandatory check now for all 👇 also SonarCloud is mandatory check now

  • asyncapi/raml-dt-schema-parser
  • asyncapi/openapi-schema-parser
  • asyncapi/avro-schema-parser
  • asyncapi/asyncapi-react
  • asyncapi/html-template
  • asyncapi/generator
  • asyncapi/template-for-generator-templates

@fmvilas
Copy link
Member

fmvilas commented Dec 10, 2020

No need to setup PR testing for below as there are no tests:

  • asyncapi/nodejs-ws-template
  • asyncapi/playground
  • asyncapi/tck

What if we just add the npm test script and it simply echoes No tests...? This way, we'll have this workflow ready for whenever we add tests in the future.

@derberg
Copy link
Member Author

derberg commented Dec 10, 2020

@fmvilas for me, the future of those 3 components is blurry and this is why I thought to pass on with them.

  • tck needs some love and probably rework if we want to use it also as a testing suite that runs for each template on PR
  • nodejs-ws-template needs to be reviewed
  • playground will change entirely

but I do not have a strong opinion here, if you insist, I can add those workflows, we can add them now or later, doesn't matter for me 👍

This was referenced Dec 10, 2020
Merged
Merged
Merged
@derberg
Copy link
Member Author

derberg commented Dec 10, 2020

@fmvilas added those workflows you requested for, please approve and we merge and wait for 💥

@derberg derberg merged commit 8a71663 into asyncapi:master Dec 10, 2020
@derberg derberg deleted the add-automated-bump branch December 10, 2020 10:58
@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Dec 10, 2020

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@derberg derberg mentioned this pull request Dec 10, 2020
Merged
@derberg
Copy link
Member Author

derberg commented Dec 10, 2020

@fmvilas it worked:

All logged nicely here -> https://github.com/asyncapi/parser-js/runs/1530107272?check_suite_focus=true

only here it didn't work https://github.com/asyncapi/nodejs-ws-template but it is because parser has a super old name there, not scoped with @asyncapi. Have a look at asyncapi/nodejs-ws-template#27

@derberg derberg mentioned this pull request Dec 10, 2020
Closed
jonastg added a commit to jonastg/parser-js that referenced this pull request Jan 18, 2021
@jonastg
Merge branch 'master' into feat/add-eslint-plugin-jsdoc
e67b253 
* master: (24 commits)
  chore: Refactored code location for iterators (asyncapi#225)
  chore(release): 1.3.1 (asyncapi#222)
  fix: apply traits to standalone messages from components section (asyncapi#214)
  test: improve feedback loop from browser tests (asyncapi#216)
  ci: fix the space-issue in bump workflow (asyncapi#218)
  ci: update global workflows (asyncapi#217)
  chore(deps): bump ini from 1.3.5 to 1.3.7 (asyncapi#215)
  ci: rename pr testing job name and test node 14 (asyncapi#213)
  ci: bump workflow to start on push instead of release (asyncapi#212)
  chore(release): 1.3.0 (asyncapi#211)
  feat: add a traverse schema function (asyncapi#198)
  ci: add workflow that bumps parser in other asyncapi repos (asyncapi#208)
  ci: fix release workflow step that is responsible for handling twitter (asyncapi#209)
  ci: update global workflows (asyncapi#206)
  ci: disable any testing on draft PR (asyncapi#204)
  chore(release): 1.2.0 (asyncapi#202)
  feat: extend the components and asyncapi model with has-like functions (asyncapi#192)
  chore(deps-dev): bump semantic-release from 17.0.6 to 17.2.3 (asyncapi#199)
  chore(release): 1.1.1 (asyncapi#197)
  fix: channels with name '/' fail on validation (asyncapi#196)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmvilas fmvilas fmvilas approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@derberg @fmvilas @asyncapi-bot