Skip to content
This repository was archived by the owner on Aug 11, 2023. It is now read-only.

Support setup.py test --coverage in affiliated packages.#39

Merged
astrofrog merged 1 commit intoastropy:masterfrom
mdboom:coverage
Mar 1, 2014
Merged

Support setup.py test --coverage in affiliated packages.#39
astrofrog merged 1 commit intoastropy:masterfrom
mdboom:coverage

Conversation

@mdboom
Copy link
Contributor

@mdboom mdboom commented Feb 27, 2014

Fixes #25. Requires astropy/astropy#2132.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a .coverage automatically created or why is it excluded here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. setup.py test --coverage will store its coverage data in .coverage.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry brain fart - I read .coveragerc.

@astrofrog
Copy link
Member

@mdboom - great, thanks! Merging this now.

@cdeil - you'll need to include these changes in gammapy for coverage testing to work.

astrofrog added a commit that referenced this pull request Mar 1, 2014
Support `setup.py test --coverage` in affiliated packages.
@astrofrog astrofrog merged commit 857b7ae into astropy:master Mar 1, 2014
@cdeil
Copy link
Member

cdeil commented Mar 2, 2014

@astrofrog I think it would be a good idea to send an email to astropy-dev every time affiliated package maintainers are supposed to update something because of changes in astropy core or the affiliated package template (and ideally the commands to do it ... is there a way to merge commits from the package-template repo into another affiliated package repo?).

In this case maybe not everyone wants it, but e.g. I am seeing this warning and don't have time to investigate what has changed and what I should do to fix it:

$ python setup.py build
/Users/deil/code/astropy2/astropy/setup_helpers.py:1002: AstropyDeprecationWarning: astropy.setup_helpers.update_package_files is deprecated.  Update your setup.py to use astropy.setup_helpers.get_package_info instead.
  AstropyDeprecationWarning)

@astrofrog
Copy link
Member

@cdeil - I agree about emailing astropy-dev. It'd be really helpful if someone else could start being responsible for maintaining, updating, advertising etc. the package-template since it's a fair bit of work to stay on top of things. If you'd be interested in taking charge of this, then let me know :)

For this change, I didn't advertise it because it's not critical and also because there will be other changes coming soon (setup and configuration) so I figured we might just want to do a sprint and update all the affiliated packages once that's all done.

Assuming an affiliated package started from the package-template, it's easy to just pull from the package-template remote and merge the changes into an existing affiliated package.

@mdboom
Copy link
Contributor Author

mdboom commented Mar 3, 2014

As @astrofrog said, since this is git, it's always possible to see what has changed in the upstream package-template and merge those changes in. It won't do the renaming of values within the files for you, of course, but I have some thoughts about how to make that easier on affiliated packages -- I just haven't had the time to really dive into it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants