Make coverage testing work for affiliated packages#2132
Merged
astrofrog merged 1 commit intoastropy:masterfrom Mar 1, 2014
Merged
Make coverage testing work for affiliated packages#2132astrofrog merged 1 commit intoastropy:masterfrom
astrofrog merged 1 commit intoastropy:masterfrom
Conversation
Member
|
I think this needs mostly be a matter of using a coveragerc relative to the package's path rather than just |
Member
|
Same issue? |
Contributor
|
This, in conjunction with astropy/package-template#39 should hopefully resolve this. |
Member
|
Is this ready to be merged? |
Member
Author
|
Yes - it seems to work correctly. I've tagged this as 0.3.2 since it can be considered a bug. |
astrofrog
added a commit
that referenced
this pull request
Mar 1, 2014
…ackages Make coverage testing work for affiliated packages
astrofrog
added a commit
that referenced
this pull request
Mar 27, 2014
…ackages Make coverage testing work for affiliated packages Conflicts: astropy/tests/helper.py
embray
added a commit
that referenced
this pull request
Apr 24, 2014
…erge of the fix for issue #2132 into the 0.3.x branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, coverage testing does not work properly for affiliated packages:
I think the culprit is that
astropy_test.runuses thecoveragercfile bundled with Astropy:which contains a hard-coded reference to
astropyas being the source directory.We should look into a way to make this more general so as to work with affiliated packages.
cc @mdboom @wkerzendorf