Python 3 and docstring fixes#70
Conversation
|
I can't figure out this warning: the object |
|
There are major problems with nedpy that I can't fix. Each nedpy function includes a table, and I think numpydoc chokes on that table, especially since it is surrounded with I really like having the tables there, but if we have to, we can just strip the docs to get builds to pass. |
|
I'm taking a look at some of the failures |
|
@keflavich - see keflavich#1 for some Python 3 fixes. |
|
How about using python-requests everywhere in From it's website:
It's a small pure-python dependency, well-done and -maintained and will make the astroquery code simpler (e.g. none of these Python 2 / 3 changes). It seems to me that would significantly lower the barrier for astronomers like me that know very little about the Python stdlib HTTP packages to be able to contribute. @keflavich @astrofrog What do you think? |
|
@cdeil - I was thinking along the same lines. I think that wherever possible, |
|
+1 to using requests - it is a pretty easy interface. I'm going to make that into its own issue. |
|
@keflavich Can you go through the issues and add labels, assignees and maybe a milestone (or add a "later" label). I'm having a hard time figuring out what I should / can be working on. Feel free to assign a few things to me ... I will ask for help if I can't figure it out. |
|
On this issue, anyone can help - the python3 failures are probably mostly a refactor need; every @cdeil - I did add milestones and labels, but honestly haven't put a ton of thought into them. I think the most interesting thing to do right now would be to work on developing the FermiLAT tool into a working example of the proposed API to make sure it really makes sense. |
|
If either of you can help with the sphinx build errors in nedpy, though, it would be greatly appreciated. The python3 errors are somewhat overwhelming - they pervade the entire code base - but the nedpy docs are at least reasonably isolated. |
Python 3 and docstring fixes. Merged as per #73 - we'll split off python3 and sphinx fixes into 2 separate PRs for future work
|
New PRs will be needed for
|
…optional Affiliated packages can opt-in to deprecations-as-exceptions
As per #64 and #67, travis is erroring on some builds because:
htmllibisHTMLParserin python3