Skip to content

Copied over latest changes from affiliated package template#64

Merged
keflavich merged 4 commits into
astropy:masterfrom
astrofrog:update-from-template-3
Apr 13, 2013
Merged

Copied over latest changes from affiliated package template#64
keflavich merged 4 commits into
astropy:masterfrom
astrofrog:update-from-template-3

Conversation

@astrofrog

Copy link
Copy Markdown
Member

This includes a revamped .travis.yml file

@astrofrog

Copy link
Copy Markdown
Member Author

@cdeil - here's the PR with the new .travis.yml file

Comment thread .travis.yml

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to keep scipy; I think there's currently a scipy dependency somewhere in astroquery

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but it just uses numpy. I'll make a PR now removing the use of scipy.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scipy doesn't get picked up from apt-get anyway, it would need to be installed by pip to be picked up (as far as I can tell).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, really? That might explain some build failures I saw in the past. Does pip install scipy work on linux? I'll remove the scipy dependency right now though

@cdeil

cdeil commented Apr 13, 2013

Copy link
Copy Markdown
Member

asciitable can be removed from .travis.yml.
The only place that uses it is test_besancon.py and there it's commented out.

@astrofrog

Copy link
Copy Markdown
Member Author

@cdeil - done

@astrofrog

Copy link
Copy Markdown
Member Author

Some tests are failing because coords doesn't install in Python 3. It looks like it's only used in 3 lines, so maybe it could easily be substituted by astropy?

@keflavich

Copy link
Copy Markdown
Contributor

I'm sure it can be - when the code was written, there was no astropy.coords. So, @cdeil, if you want to give that a shot, do it, otherwise I'll try to take it on this evening.

@cdeil

cdeil commented Apr 13, 2013

Copy link
Copy Markdown
Member

I'm doing it right now.

@astrofrog

Copy link
Copy Markdown
Member Author

@keflavich @cdeil I think we should just merge this, and then address the failures.

@cdeil

cdeil commented Apr 13, 2013

Copy link
Copy Markdown
Member

+1 to merging this now.

@astrofrog

Copy link
Copy Markdown
Member Author

@keflavich - shall I merge?

keflavich added a commit that referenced this pull request Apr 13, 2013
Copied over latest changes from affiliated package template
@keflavich keflavich merged commit 0fadb80 into astropy:master Apr 13, 2013
@keflavich

Copy link
Copy Markdown
Contributor

Failed on a threading issue: https://travis-ci.org/astropy/astroquery/jobs/6314837. Should we be concerned? I'll assume no unless subsequent builds fail with the same error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants