Add big-endian s390 architecture on travis#9663
Conversation
c9194cc to
cb512b6
Compare
|
@mhvk I am afraid that this may be not that simple: It is usually not a good idea to mix packages between distributions or even releases of the same distribution; often enough this ends in an unusable system. |
698f1eb to
36274af
Compare
|
@olebole - hmm, maybe true, but since Ubuntu is just Debian with a bit of veneer, little of which is relevant for running code, it must be possible! And after about a dozen trials, indeed it is! (Though ideally I would not rely on To me, it seems this would be good enough to put in a cron job at least - let me ping @bsipocz |
36274af to
46d65ae
Compare
|
@bsipocz - obviously, the two commits with fixes can be pulled out of this PR! Though I do think there is little reason not to test on |
|
@olebole - the other reason I like adding this is that it would be good to test a completely apt-based installation; it is no less valid an environment that one using |
|
I've moved the milestone to 4.1 - no real hurry here. |
db87351 to
173a3d1
Compare
|
There are some errors for installing optional dependencies, but otherwise it seems to work nicely, and the total job runtime of 8 minutes is not bad! |
|
Yes, I finally got it going again... Not having |
|
With @pllim excellent detective work, it seems that adding |
|
The weird thing is Line 4 in f08737a so why is it missing? |
173a3d1 to
e4c36f0
Compare
|
Still has the |
7e08f53 to
bbe8e40
Compare
|
Hurray, tests now pass on s390! Which brings up the question of what this should replace. In a way, by design it is somewhat orthogonal already to everything that is there, no only testing big-endian (main purpose) but also testing that standard debian (and therefore ubuntu) packages would do the trick. But I do not want to increase the number of tests. Looking at the present set, we test all dependencies four times:
This seems too much and my suggestion would be to move all of these "one up" (deleting the first), i.e., have an initial test with all oldest supported versions (most likely to fail), comprensive tests on linux/windows, and final tests as they are. Alternatively/additionally, I could move this new test to the cron section. @bsipocz - what do you think? If it is easier, I can just move it to cron here and open a separate issue about reducing the number of tests generally. |
|
OK, so I would do is to indeed remove the no1, and replace it with no3 but changing the python version to 3.8. I feel we have more breakage due to upstream updates rather than with old versions, so would keep the most up to date one in the initial set. As to whether cron or not cron, I don't have strong preference. If we expect this new job to fail on ordinary PRs, then it should stay in the main matrix, but if breakage is infrequent (like for the osx one), then a cron is sufficient. I don't think we need another issue for lowering the number of builds, we gone through it a few times as it's not really possible to squeeze them any more. |
|
@bsipocz - decided it made more sense to just move the stage to cron for |
bsipocz
left a comment
There was a problem hiding this comment.
Looks good!
Do you plan to reschuffle the rest of the jobs as we discussed above? or would you mind me to push a commit here that does it here rather than opening another minimal PR?
|
Thanks @mhvk! |
|
|
|
Thanks, let me know if the backport proves troublesome - I'll keep #9670 around just to have a sense how the override used to look like before |
Hopefully I disabled everything else.(EDIT, now ready for real review)This follows the suggestion of @olebole to try adding the big-ending s390 architecture to our tests. It relies on all our build-dependencies being available via
apt.