Skip to content

[DO NOT MERGE] Test all with s390#9670

Closed
mhvk wants to merge 6 commits intoastropy:masterfrom
mhvk:travis-try-s390-all
Closed

[DO NOT MERGE] Test all with s390#9670
mhvk wants to merge 6 commits intoastropy:masterfrom
mhvk:travis-try-s390-all

Conversation

@mhvk
Copy link
Contributor

@mhvk mhvk commented Nov 25, 2019 •
edited
Loading

Check whether we can do the *tab.py regeneration as part of the s390 run, aiming to mimic Debian installation. Logically, eventually one would do this with use_system_libraries, but cannot do that yet since erfa needs updating (#9654)

EDIT: with use_system_libraries, one could remove some stuff but needs to add (see https://packages.debian.org/source/unstable/astropy)

# rm -rf cextern
libcfitsio-dev liberfa-dev libexpat1-dev wcslib-dev
# rm -rf astropy/extern (or rather replace with imports).
python3-configobj libjs-jquery-datatables libjs-mathjax python3-ply
# rm -rf astropy_helpers
python3-astropy-helpers

For docs, one would also need

python3-sphinx-astropy

@mhvk mhvk mentioned this pull request Mar 21, 2020
Merged
@astropy-bot
Copy link

astropy-bot bot commented Apr 28, 2020

Hi humans 👋 - this pull request hasn't had any new commits for approximately 5 months. I plan to close this in a month if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

@bsipocz
Copy link
Member

bsipocz commented Apr 28, 2020

I think this can safely closed now as the s390x test has been added a while ago now.

@bsipocz bsipocz closed this Apr 28, 2020
@mhvk
Copy link
Contributor Author

mhvk commented Apr 28, 2020

It was not quite the same thing, but I agree, there's really not that much need to try to test everything on s390.

@bsipocz
Copy link
Member

bsipocz commented Apr 28, 2020

@mhvk - oh, I'm sorry then to close it. Please do reopen and resurrect the part we can still use from here.

@mhvk
Copy link
Contributor Author

mhvk commented Apr 28, 2020

No, don't worry, I think this was overkill anyway...

@mhvk mhvk deleted the travis-try-s390-all branch October 10, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Experimental testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mhvk @bsipocz