Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

• Do the proposed changes actually accomplish desired goals?
• Do the proposed changes follow the Astropy coding guidelines?
• Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
• Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
• Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
• Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
• Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
• Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
• At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

Remote data job failure is unrelated.

Can we do this for 8.0? I released pyvo 1.9 this week, and started to get reports of it colliding with astropy, so I wonder if we could get in the deprecation sooner rather than in 2 years down the line.

cc @astrofrog @andamian @tomdonaldson

Fine by me!

Do you have a preference of just simply deprecate or making pyvo a dependency and pulling the functionality from it?

(I would expect the latter approach would resolve the samp-hub cli issue we got reported about in pyvo)

Fine by me!

@astrofrog - this should be ready to review and merge then.

Just to double check, is samp ready to use in pyvo?

Just to double check, is samp ready to use in pyvo?

Yes, it should be, at least the astropy version got ported over as is. But let me check with the other maintainers.

@bsipocz - thanks, once you know for sure that it's ready to go, can you also open a PR to the v8.0.x branch to add a what's new entry?

@bsipocz - thanks, once you know for sure that it's ready to go, can you also open a PR to the v8.0.x branch to add a what's new entry?

Sure. What's new only goes into the backport PR, right?

Whoa, that moved fast. One weekend I didn't check email and the ring was already tossed into Mt. Doom. 😆

I opened #19874 as follow-up. Thanks, all!

For completeness: https://groups.google.com/g/astropy-dev/c/8jE7EGhtic0

Whoa, that moved fast. One weekend I didn't check email and the ring was already tossed into Mt. Doom. 😆
I opened #19874 as follow-up. Thanks, all!

Well, I was working with the assumption that astropy wanted to get rid of this module for at least half a decade, so no need to drag it on for longer.