Skip to content

Backport PR #19373 on branch v8.0.x (API: Deprecate astropy.samp)#19872

Merged
bsipocz merged 3 commits into
astropy:v8.0.xfrom
meeseeksmachine:auto-backport-of-pr-19373-on-v8.0.x
Jun 8, 2026
Merged

Backport PR #19373 on branch v8.0.x (API: Deprecate astropy.samp)#19872
bsipocz merged 3 commits into
astropy:v8.0.xfrom
meeseeksmachine:auto-backport-of-pr-19373-on-v8.0.x

Conversation

@meeseeksmachine

Copy link
Copy Markdown

Backport PR #19373: API: Deprecate astropy.samp

@lumberbot-app lumberbot-app Bot added this to the v8.0.0 milestone Jun 8, 2026
@lumberbot-app lumberbot-app Bot added Docs samp API change PRs and issues that change an existing API, possibly requiring a deprecation period Downstream Fix Required backport-v8.0.x on-merge: backport to v8.0.x labels Jun 8, 2026
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@bsipocz bsipocz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR itself is good to go, the CI status is unrelated failures.

@bsipocz bsipocz merged commit e4492e0 into astropy:v8.0.x Jun 8, 2026
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API change PRs and issues that change an existing API, possibly requiring a deprecation period backport-v8.0.x on-merge: backport to v8.0.x Docs Downstream Fix Required samp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants