TST: Move Linux ARM64 job from cron to CI by pllim · Pull Request #17657 · astropy/astropy

pllim · 2025-01-23T02:49:17Z

Description

This pull request is to fix #17656

After merge

~~Add new job as "required" in branch protection.~~

By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

github-actions · 2025-01-23T02:49:42Z

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

Do the proposed changes actually accomplish desired goals?
Do the proposed changes follow the Astropy coding guidelines?
Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

github-actions · 2025-01-23T02:49:44Z

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

bsipocz

Looks good, one minor comment to consider.

bsipocz · 2025-01-23T04:05:01Z

.github/workflows/ci_workflows.yml

      targets: |
        - cp311-manylinux_x86_64
+
+  test_arm64:


now that this runs in the main matrix, you may want to consider removing one of the other linux jobs?

Any suggestion? It still needs to be a separate job due to different env var, I think.

All the existing Linux jobs seem to be specialized (all deps, cov, run twice, etc). And I am not sure which one is most suited to use this new runner.

It still needs to be a separate job due to different env var, I think.

It shouldn't you can set per-job env vars: https://github-actions-workflows.openastronomy.org/en/latest/tox.html#setenv

Why not let the arm job do the run-twice or so? That would seem unlikely to be architecture dependent.

I have to check the runner specs again. I think we have to reduce -n=4 to -n=2 if we switch. Is that a problem?

Oh nvm... maybe we get 4 still. I must be confused with the paid one. https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

bsipocz · 2025-01-23T04:06:27Z

Also, maybe backport or have this add to the CI on the bugfix branch, too.

pllim · 2025-01-23T16:33:59Z

Huh... I applied the suggestions and the job failed pretty fast but error is cryptic to me. Not sure if it is related to the yellow GitHub status or not.

Cadair · 2025-01-23T16:36:20Z

.github/workflows/ci_workflows.yml

@@ -93,6 +93,10 @@ jobs:

        - name: Python 3.11 Double test (Run tests twice)


Suggested change

- name: Python 3.11 Double test (Run tests twice)

- name: Python 3.11 Double test (Run tests twice) [aarch64]

But then I have to go update the branch protection and all the PRs will need rebasing. 😬

@bsipocz and @mhvk , any preference about keeping or changing job name?

Happy to leave as is to avoid giving people pain, but even happier to leave the decision up to you!

Honestly, I would put this as the first word as the most important attribute of the job (as the end will be chopped down anyway), but also it doesn't matter much if too much pain.

Maybe we can do it when we bump Python version in the future since the name would change anyway...

Cadair · 2025-01-23T16:43:00Z

yeah it looks like it failed on git checkout so I would say that's a service issue.

[ci skip]

pllim · 2025-01-23T21:37:45Z

Thanks, all!

Backport PR #17657: TST: Move Linux ARM64 job from cron to CI

pllim added the no-changelog-entry-needed label Jan 23, 2025

pllim added this to the v7.1.0 milestone Jan 23, 2025

github-actions bot added the testing label Jan 23, 2025

pllim marked this pull request as ready for review January 23, 2025 02:57

pllim requested review from a team and Cadair January 23, 2025 02:57

bsipocz approved these changes Jan 23, 2025

View reviewed changes

This comment was marked as resolved.

Sign in to view

pllim added 2 commits January 23, 2025 11:07

TST: Move Linux ARM64 job from cron to CI

aac2d6b

Address review comments

19967ce

pllim force-pushed the free-arm-2 branch from 34dd253 to 19967ce Compare January 23, 2025 16:31

pllim modified the milestones: v7.1.0, v7.0.1 Jan 23, 2025

pllim added the backport-v7.0.x label Jan 23, 2025

Cadair reviewed Jan 23, 2025

View reviewed changes

pllim modified the milestone: v7.0.1 Jan 23, 2025

pllim added 2 commits January 23, 2025 12:37

Have to redefine IS_CRON also

4780208

Add reminder for future

2237f20

[ci skip]

pllim merged commit 7ef2800 into astropy:main Jan 23, 2025
0 of 2 checks passed

This comment was marked as resolved.

Sign in to view

lumberbot-app bot added the Still Needs Manual Backport label Jan 23, 2025

pllim deleted the free-arm-2 branch January 23, 2025 21:37

pllim added a commit to pllim/astropy that referenced this pull request Jan 23, 2025

Backport PR astropy#17657: TST: Move Linux ARM64 job from cron to CI

6aa2c3d

pllim mentioned this pull request Jan 23, 2025

Backport PR #17657: TST: Move Linux ARM64 job from cron to CI #17660

Merged

1 task

pllim removed the Still Needs Manual Backport label Jan 23, 2025

pllim added a commit that referenced this pull request Jan 23, 2025

Merge pull request #17660 from pllim/backport-pr17657-v7.0.x

8141b03

Backport PR #17657: TST: Move Linux ARM64 job from cron to CI

		@@ -93,6 +93,10 @@ jobs:

		- name: Python 3.11 Double test (Run tests twice)

Uh oh!

Conversation

pllim commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

After merge

Uh oh!

github-actions bot commented Jan 23, 2025

Uh oh!

github-actions bot commented Jan 23, 2025

Uh oh!

bsipocz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bsipocz commented Jan 23, 2025

Uh oh!

This comment was marked as resolved.

pllim commented Jan 23, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Cadair commented Jan 23, 2025

Uh oh!

Uh oh!

This comment was marked as resolved.

pllim commented Jan 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pllim commented Jan 23, 2025 •

edited

Loading