Skip to content

TST: fix compatibility pytest 8.0 (episode 2)#15961

Merged
pllim merged 4 commits intoastropy:mainfrom
neutrinoceros:tst/pytest8_compat2
Jan 30, 2024
Merged

TST: fix compatibility pytest 8.0 (episode 2)#15961
pllim merged 4 commits intoastropy:mainfrom
neutrinoceros:tst/pytest8_compat2

Conversation

@neutrinoceros
Copy link
Copy Markdown
Contributor

@neutrinoceros neutrinoceros commented Jan 28, 2024

Description

A follow up to #15809
Fixes #15960 (🤞🏻)

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros
Copy link
Copy Markdown
Contributor Author

Not all parts of #15960 are resolved yet, but I won't be able to contribute anything more until this Wednesday, so I'm undrafting this to let others merge it as is, if needed. Feel free to push to this branch while I'm away !

@neutrinoceros neutrinoceros marked this pull request as ready for review January 29, 2024 09:34
@pllim

This comment was marked as resolved.

@neutrinoceros neutrinoceros requested a review from mcara as a code owner January 30, 2024 14:58
@pllim pllim added the Extra CI Run cron CI as part of PR label Jan 30, 2024
@pllim
Copy link
Copy Markdown
Member

pllim commented Jan 30, 2024

Let's also run the cron jobs, just in case. 🤞

@pllim
Copy link
Copy Markdown
Member

pllim commented Jan 30, 2024

Link check failure is unrelated (still waiting to hear back from OSU).

@eerovaher eerovaher force-pushed the tst/pytest8_compat2 branch from 49e1b1b to 208d54b Compare January 30, 2024 16:34
@eerovaher
Copy link
Copy Markdown
Member

I have cleaned up the commit history to my liking. If all the commits would have been authored by a single person I would have combined all the patches into one, but that's not the case, so there are multiple commits to preserve authorship information.

As far as I can tell this should be good to merge, but because I am the committer of all the commits here then I shouldn't approve this formally.

@eerovaher eerovaher force-pushed the tst/pytest8_compat2 branch from 208d54b to bfc2569 Compare January 30, 2024 16:55
Copy link
Copy Markdown
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM now. Thanks, all!

I will not use auto-merge because I want to make sure the non-required jobs are also green before I merge.

pllim added a commit that referenced this pull request Jan 30, 2024
…961-on-v6.0.x

Backport PR #15961 on branch v6.0.x (TST: fix compatibility pytest 8.0 (episode 2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TST: CI is currently unstable against pytest 8.0

3 participants