Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

• Do the proposed changes actually accomplish desired goals?
• Do the proposed changes follow the Astropy coding guidelines?
• Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
• Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
• Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
• Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
• Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
• Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
• Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
• At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

Thanks! Failures only show up in the predeps job in daily cron, so I just kicked off the cron jobs.

Maybe I need to add remote data directive to the devinfra job below because these were obviously overlooked. Not sure why I didn't catch these in #15054 ; that PR also had cron jobs run.

Huh why is devinfra even failing here? I have restarted a previously passing build on main from 3 days ago to see if this is even related or not to this PR: https://github.com/astropy/astropy/actions/runs/7375363390

pluggy._manager.PluginValidationError: Plugin 'pytest_filter_subpackage' for hook 'pytest_ignore_collect'
hookimpl definition: pytest_ignore_collect(path, config)

UPDATE: Previously successful build now fails on rerun, so we can ignore devinfra failure in this PR.

This failure is related: https://github.com/astropy/astropy/actions/runs/7412818159/job/20170416343?pr=15809

Oh good catch. You actually reported it already but I didn't see it locally so I assumed it was gone. I can look this one first thing tomorrow but feel free to push to this branch in the mean time if it's considered urgent.

if it's considered urgent

Since pytest 8.0 is still in RC stage and not released, not super urgent. I can wait. Thanks!

I'll worry about the remaining failures later. One fire at a time. Thanks!

Note for my future self: I was thinking about adding --remote-data to devinfra to catch things like this earlier but then I realized devdeps would also pick up pre-releases, and devdeps runs a lot via CI for PRs, so maybe existing setup is enough? If someone feels otherwise, feel free to open follow-up issue or PR.

UPDATE: I think I confused myself. --remote-data isn't the problem here. predeps install all dependencies but not devdeps and not sure if we want to.