TST: Skip test_ignore_sigint in predeps job#15818
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
👋 Thank you for your draft pull request! Do you know that you can use |
This comment was marked as resolved.
This comment was marked as resolved.
because I do not know how to fix it for all the jobs all at once. See PR 15817 for failed attempt.
instead of skipping it blindly
2a04b61 to
8059e1b
Compare
|
@saimn , now it is skipping based on thread count as you suggested but the skip check has to happen at run time, not collection time. Does this look good to you? It does fix the predeps job. Other failures are unrelated (exotic archs still running when I typed this). |
|
I really want this failure to go away so I can test other pytest 8.0rc stuff. Merging. If you disagree, feel free to open follow-up PR. Thanks! |
…818-on-v6.0.x Backport PR #15818 on branch v6.0.x (TST: Skip test_ignore_sigint in predeps job)
|
@pllim - Looks good to me, thanks! (Indeed checking the number of threads must be done when running the test, otherwise the other threads are not alive). |
|
BTW @saimn , chanley said the fix was necessary 17 years ago for something but he didn't have the resources to implement it also for new buffer. So, I don't think we should remove it but I am also not sure if it is worth our time to implement it for new buffer. 🤷♀️ |
Description
Because I do not know how to fix it for all the jobs all at once. See #15817 for failed attempt.
This is a direct follow-up of #15809 to fix #15807 . One way we can fix #15827 .