Skip to content

Avoid deprecation warning in wcsaxes doc#11466

Merged
pllim merged 1 commit into
astropy:masterfrom
nstarman:patch_matplotlib_3.4.1_error
Apr 2, 2021
Merged

Avoid deprecation warning in wcsaxes doc#11466
pllim merged 1 commit into
astropy:masterfrom
nstarman:patch_matplotlib_3.4.1_error

Conversation

@nstarman

@nstarman nstarman commented Apr 2, 2021

Copy link
Copy Markdown
Member

@pllim

This comment has been minimized.

@nstarman

nstarman commented Apr 2, 2021

Copy link
Copy Markdown
Member Author

@pllim It's still running! but RTD is still bringing up the warning.

The validCap attribute was deprecated in Matplotlib 3.4 and will be removed two minor releases later.
  return getattr(obj, attr, *defargs)

I don't know what the difference is between #11118 and this, but it looks like #11464 might still be necessary. 😰.

@pllim

pllim commented Apr 2, 2021

Copy link
Copy Markdown
Member

As long as RTD doesn't fail, I don't really care if the warnings are there or not anymore. I feel like we have wasted too much time on this... 😅

@pllim

pllim commented Apr 2, 2021

Copy link
Copy Markdown
Member

FWIW, I have been playing with different directives from Sphinx autodoc and our own sphinx-automodapi but these warnings are very hard to get rid of. I have a feeling that sphinx_automodapi/autodoc_enhancements.py#L71 happens before all the skipping stuff.

@pllim

This comment has been minimized.

- Temporary fix to matplotlib/matplotlib#19839,
- from astropy#11118,
- closes (?) astropy#11464

Co-authored-by: @pllim
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@nstarman nstarman force-pushed the patch_matplotlib_3.4.1_error branch from 81324aa to 1a40abc Compare April 2, 2021 18:49
@nstarman

nstarman commented Apr 2, 2021

Copy link
Copy Markdown
Member Author

@pllim @eteq , RTD compiles 🥳

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@pllim pllim merged commit 3973639 into astropy:master Apr 2, 2021
@nstarman nstarman deleted the patch_matplotlib_3.4.1_error branch April 2, 2021 19:24
@pllim

pllim commented Apr 2, 2021

Copy link
Copy Markdown
Member

Manual backport for this is #11468 and hopefully we won't need anymore backports given this is a temporary solution.

@nstarman

nstarman commented Apr 2, 2021

Copy link
Copy Markdown
Member Author

@pllim, is this something I should do? how does one PR a backport?

@pllim

pllim commented Apr 2, 2021

Copy link
Copy Markdown
Member

@nstarman , don't worry about the backports. The release managers take care of that and we have helper scripts. 😄 Thanks again for your fix!

@pllim

pllim commented Apr 30, 2021

Copy link
Copy Markdown
Member

I think we need to backport this. I see the same warnings on RTD build for LTS, causing it to fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants