Skip to content

Avoid deprecation warning in wcsaxes doc in 4.2.x#11468

Merged
pllim merged 1 commit into
astropy:v4.2.xfrom
eteq:fix-rtd-mpl-nopin
Apr 2, 2021
Merged

Avoid deprecation warning in wcsaxes doc in 4.2.x#11468
pllim merged 1 commit into
astropy:v4.2.xfrom
eteq:fix-rtd-mpl-nopin

Conversation

@eteq

@eteq eteq commented Apr 2, 2021 •
edited by pllim
Loading

Copy link
Copy Markdown
Member

This is an alternative to #11465 that instead follows the fix on #11466 . If this works on RTD, I think I prefer it for a 4.2.1post1 over #11465 !

EDIT: Close #11465

@nstarman @eteq
Avoid deprecation warning in wcsaxes doc
a02e400 
- Temporary fix to matplotlib/matplotlib#19839,
- from astropy#11118,
- closes (?) astropy#11464

Co-authored-by: @pllim
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@eteq eteq mentioned this pull request Apr 2, 2021
Closed
@pllim

pllim commented Apr 2, 2021

Copy link
Copy Markdown
Member

RTD passed!

@pllim

pllim commented Apr 2, 2021

Copy link
Copy Markdown
Member

I still see the warnings but at least they don't block the CI... 🤷

.../sphinx_automodapi/autodoc_enhancements.py:71: MatplotlibDeprecationWarning: 
The validCap attribute was deprecated in Matplotlib 3.4 and will be removed two minor releases later.
  return getattr(obj, attr, *defargs)
.../sphinx_automodapi/autodoc_enhancements.py:71: MatplotlibDeprecationWarning: 
The validJoin attribute was deprecated in Matplotlib 3.4 and will be removed two minor releases later.
  return getattr(obj, attr, *defargs)

pllim
pllim approved these changes Apr 2, 2021
View reviewed changes

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can ignore samp failure and dev failures.

@eteq , :shipit: ?

@pllim pllim added this to the v4.2.1 milestone Apr 2, 2021
@pllim pllim merged commit 3ee62e5 into astropy:v4.2.x Apr 2, 2021
This was referenced Apr 2, 2021
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim approved these changes

Assignees

No one assigned

Labels

Docs no-changelog-entry-needed visualization.wcsaxes

Projects

None yet

Milestone

v4.2.1

Development

Successfully merging this pull request may close these issues.

3 participants

@eteq @pllim @nstarman