Skip to content

pin matplotlib to <3.4 in 4.2.x#11465

Closed
eteq wants to merge 1 commit into
astropy:v4.2.xfrom
eteq:fix-rtd-mpl
Closed

pin matplotlib to <3.4 in 4.2.x#11465
eteq wants to merge 1 commit into
astropy:v4.2.xfrom
eteq:fix-rtd-mpl

Conversation

@eteq

@eteq eteq commented Apr 2, 2021

Copy link
Copy Markdown
Member

This is for the 4.2.x branch, as a potential change for a 4.2.1post1 just to get the RTD build working.

@eteq eteq changed the title pin matplotlib to <3.4 pin matplotlib to <3.4 in 4.2.x Apr 2, 2021
@pllim

pllim commented Apr 2, 2021

Copy link
Copy Markdown
Member

The samp failure is fixed by #11447 -- FYI

@pllim

pllim commented Apr 2, 2021

Copy link
Copy Markdown
Member

RTD passed and the failures thus far are known issues and non-blocking... 🤞

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is good enough for a bugfix branch, unless you prefer something else like #11466 (if it works).

Comment thread setup.cfg
PyYAML>=3.13
scipy>=1.1
matplotlib>=3.1
matplotlib>=3.1, <3.4.0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tried, just pinning it here wasn't enough because all overwrites it. I had to pin it like in #11462 .

@pllim

pllim commented Apr 2, 2021

Copy link
Copy Markdown
Member

Eh,.... RTD passed! Maybe I am going crazy.

@pllim

pllim commented Apr 2, 2021

Copy link
Copy Markdown
Member

Ah,,, because we skipped the !=3.4.0 pin here.

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving to remove the block. I'll leave it up to you as the release manager if this is good enough or you want a solution that is consistent with master (not sure what yet).

@eteq

eteq commented Apr 2, 2021

Copy link
Copy Markdown
Member Author

I made #11468 because I think @nstarman's solution is better if it works! But if that doesn't work in 4.2.x out-of-the-box it's not worth the trouble right now, and instead we should go with this one.

@pllim

pllim commented Apr 2, 2021

Copy link
Copy Markdown
Member

Closed without merge in favor of #11468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants