Skip to content

fix(sequencer) fix wrong metric and remove unused metric#1240

Merged
noot merged 2 commits intomainfrom
noot/fix-metric
Jul 6, 2024
Merged

fix(sequencer) fix wrong metric and remove unused metric#1240
noot merged 2 commits intomainfrom
noot/fix-metric

Conversation

@noot
Copy link
Copy Markdown
Contributor

@noot noot commented Jul 5, 2024

Summary

decode failure was being recorded instead of the correct execution failure metric.

decode failure is no longer used anywhere so it was removed

Changes

  • see summary

Testing

unit tests

@noot noot marked this pull request as ready for review July 5, 2024 17:15
@noot noot requested a review from a team as a code owner July 5, 2024 17:15
@noot noot requested a review from Fraser999 July 5, 2024 17:15
@github-actions github-actions bot added the sequencer pertaining to the astria-sequencer crate label Jul 5, 2024
@noot noot added this pull request to the merge queue Jul 6, 2024
Merged via the queue into main with commit c90005d Jul 6, 2024
@noot noot deleted the noot/fix-metric branch July 6, 2024 16:49
steezeburger added a commit that referenced this pull request Jul 11, 2024
* main: (27 commits)
  refactor(sequencer): fix prepare proposal metrics (#1211)
  refactor(bridge-withdrawer): move generated contract bindings to crate (#1237)
  fix(sequencer) fix wrong metric and remove unused metric (#1240)
  feat(sequencer): implement transaction fee query (#1196)
  chore(cli)!: remove unmaintained rollup subcommand (#1235)
  release(sequencer): 0.14.1 patch release (#1233)
  feat(sequencer-utils): generate example genesis state (#1224)
  feat(sequencer): implement abci query for bridge account info (#1189)
  feat(charts): bridge-withdrawer, smoke test, various chart improvements (#1141)
  chore(charts): update for new geth update (#1226)
  chore(chart)!: dusk-8 chart version updates (#1223)
  release(conductor): fix conductor release version (#1222)
  release: dusk-8 versions (#1219)
  fix(core): revert `From` ed25519_consensus types for crypto mod (#1220)
  Refactor(chart, sequencer): restructure sequencer chart, adjust configs (#1193)
  refactor(withdrawer): read from block subscription stream and get events on each block (#1207)
  feat(core): implement with verification key for address builder and crypto improvements (#1218)
  feat(proto, sequencer)!: use full IBC ICS20 denoms instead of IDs (#1209)
  chore(chart): update evm chart for new prefix field (#1214)
  chore: bump penumbra deps (#1216)
  ...
bharath-123 pushed a commit that referenced this pull request Jul 25, 2024
## Summary
decode failure was being recorded instead of the correct execution
failure metric.

decode failure is no longer used anywhere so it was removed

## Changes
- see summary

## Testing
unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sequencer pertaining to the astria-sequencer crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants