refactor(sequencer): fix prepare proposal metrics#1211
Merged
lobstergrindset merged 2 commits intomainfrom Jul 8, 2024
Merged
Conversation
lobstergrindset
commented
Jun 26, 2024
| // removed from the mempool in `update_mempool_after_finalization`. | ||
| txs_to_readd_to_mempool.push((enqueued_tx, priority)); | ||
| } else { | ||
| failed_tx_count = failed_tx_count.saturating_add(1); |
Contributor
Author
There was a problem hiding this comment.
I'm not really sure what this log is for. Do we use it for alters somewhere? I moved it down here so we could have an accurate count for the excluded transactions gauge.
Contributor
There was a problem hiding this comment.
pretty sure it's only used for logging at the moment, but useful to have
noot
approved these changes
Jun 28, 2024
steezeburger
added a commit
that referenced
this pull request
Jul 11, 2024
* main: (27 commits) refactor(sequencer): fix prepare proposal metrics (#1211) refactor(bridge-withdrawer): move generated contract bindings to crate (#1237) fix(sequencer) fix wrong metric and remove unused metric (#1240) feat(sequencer): implement transaction fee query (#1196) chore(cli)!: remove unmaintained rollup subcommand (#1235) release(sequencer): 0.14.1 patch release (#1233) feat(sequencer-utils): generate example genesis state (#1224) feat(sequencer): implement abci query for bridge account info (#1189) feat(charts): bridge-withdrawer, smoke test, various chart improvements (#1141) chore(charts): update for new geth update (#1226) chore(chart)!: dusk-8 chart version updates (#1223) release(conductor): fix conductor release version (#1222) release: dusk-8 versions (#1219) fix(core): revert `From` ed25519_consensus types for crypto mod (#1220) Refactor(chart, sequencer): restructure sequencer chart, adjust configs (#1193) refactor(withdrawer): read from block subscription stream and get events on each block (#1207) feat(core): implement with verification key for address builder and crypto improvements (#1218) feat(proto, sequencer)!: use full IBC ICS20 denoms instead of IDs (#1209) chore(chart): update evm chart for new prefix field (#1214) chore: bump penumbra deps (#1216) ...
bharath-123
pushed a commit
that referenced
this pull request
Jul 25, 2024
## Summary The sequencer's `prepare_proposal()` metrics got shifted to `process_proposal()` across some refactors. ## Changes Put metrics back in proper places and removed unneeded metric. ## Testing Ran locally ## Metrics Removed the `PREPARE_PROPOSAL_EXCLUDED_TRANSACTIONS_DECODE_FAILURE` metric as the mempool should be filtering these transactions out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The sequencer's
prepare_proposal()metrics got shifted toprocess_proposal()across some refactors.Changes
Put metrics back in proper places and removed unneeded metric.
Testing
Ran locally
Metrics
Removed the
PREPARE_PROPOSAL_EXCLUDED_TRANSACTIONS_DECODE_FAILUREmetric as the mempool should be filtering these transactions out.