Add manylinux_2_31 to supported --python-platform#4965
Merged
charliermarsh merged 1 commit intomainfrom Jul 10, 2024
Merged
Conversation
filaretov
added a commit
to filaretov/uv
that referenced
this pull request
Nov 19, 2024
PR astral-sh#4965 added `*-manylinux_2_31` as a target triple, and issue astral-sh#4966 described the need for a more general solution. In lieu of a general solution, this PR adds further explicit manylinux target triples for different glibc version up to the one used by the latest Ubuntu release (2.40).
charliermarsh
pushed a commit
that referenced
this pull request
Nov 19, 2024
<!-- Thank you for contributing to uv! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? - Does this pull request include references to any relevant issues? --> ## Summary <!-- What's the purpose of the change? What does it do, and why? --> PR #4965 added `*-manylinux_2_31` as a target triple, and issue #4966 described the need for a more general solution. In lieu of a general solution, this PR adds further explicit manylinux target triples for different glibc version up to the one used by the latest Ubuntu release (glibc 2.40 used in Ubuntu 24.10). ## Test Plan <!-- How was it tested? --> Local, manual testing with a Python wheel targeting `x86_64-manylinux_2_35`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I'll make an issue for arbitrary
manylinux_x_ysupport.Closes #4956.