Broadcast WM_SETTINGCHANGE on uv tool update-shell #17404
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #17331
Certain applications on windows expect to be notified when environment variables change such as conhost.exe (traditional cmd.exe host).
Without this notification conhost.exe will not pick up changes to environment variables regardless of how many times conhost.exe is re-launched after running
uv tool update-shell.Test Plan
Before this change
%USERPROFILE%\.local\binfrom environment variables via UI (which sendsWM_SETTINGCHANGE)%SYSTEMROOT%\System32\conhost.exeand attempted to run any tool preivously installed. It fails to find any.uv tool update-shell. ConfirmedHKEY_CURRENT_USER\Environment\Pathwas updated in registry.%SYSTEMROOT%\System32\conhost.exesession. Fails to find installed tools.After this change
%USERPROFILE%\.local\binfrom environment variables via UI (which sendsWM_SETTINGCHANGE)%SYSTEMROOT%\System32\conhost.exeand attempted to run any tool preivously installed. It fails to find any.uv tool update-shell. ConfirmedHKEY_CURRENT_USER\Environment\Pathwas updated in registry.%SYSTEMROOT%\System32\conhost.exesession. Finds the installed tools.