Funny, this doesn't change anything with my terminal color scheme :)

Isn't it more likely to have users with dimm black terminal (Who would have worse readability then) than users with dimm Green terminal?
Just a thought.

Readability is also improved with dark background, see my screenshot. The point is that you see the actual progress, not so much the unfinished bars to the right.

Readability is also improved with dark background, see my screenshot.

The dark mode is not universal and many people have different "dark mode" terminal color. My point is that it may be that some users may have the exact color you used as a background color, making them lose readability. Of course, people may also have "dark green" background (in which case, the previous colors would be worse), but my point is that the latter is less likely than the former, isn't it?

My point only stands if the internals define a hardcoded color though, I don't know if it's the case?

Just so you know, here's the situation locally on my side on a PowrShell (I don't really use that, but people may)

Previous version

Your improved version

As you can see, previous version was bad, and your version is better, but still shows complete black for incomplete part. In this case, it's still a win, but if the former version was working well (with an actual dark green), then your update would be a regression on my side.

@eliegoudout don't you think this is clearly better? This change is intentional, you can actually see the progress, whereas previously, I can see only one single green bar. I get it that on some terminals with black background, dimmed black might be pure black, but since it is clear where the 100% mark is, you can still see the progress (because the green color wasn't changed at all, it is just better visible now). Or do you have to see the unfinished (remaining) part of the bar (and if so why)?

I think this also heavily depends on the terminal you are using. Which one is it?

don't you think this is clearly better?

First of all, yes! On the screens I provided, the new version is clearly better. But I tink this is only because my console does not show the correct colors for the first version (dimmed green), no?

I would have liked to see the rendering for your console before your PR.

My point is simply that previously, since the colors were green vs dimmed green, there was almost no risk of a user having the dimmed green badly displayed. However, with the new version (green vs dimmed black), there is a greater risk or users having a "conflict of colors" with their own console background.

Honestly, I think it's just splitting hairs at this point, but I was simply sharing my (very mild) concern :)

I think this also heavily depends on the terminal you are using. Which one is it?

The default (i think) Windows PowerShell terminal

No worries, I think it is good to discuss any regressions!

I would have liked to see the rendering for your console before your PR.

I posted it here. This was the intended look, and it was really hard to distinguish the two green colors.

My point is simply that previously, since the colors were green vs dimmed green, there was almost no risk of a user having the dimmed green badly displayed. However, with the new version (green vs dimmed black), there is a greater risk or users having a "conflict of colors" with their own console background.

True, but even if a dark (dimmed black) background makes the right portion of the bar invisible now, the progress is still clearly visible. So even this special case is an improvement vs. the previous green/dimmed green IMO.

The default (i think) Windows PowerShell terminal

It looks like special (Unicode?) characters are not working either for you. I recommend Windows Terminal (and not Command Prompt aka cmd.exe) on Windows; this should fix both the colors and the Unicode issues.

Thanks for your answer! Indeed, the previous renders your showed are pretty bad! And you're right that even if the incomplete part is invisible, it's still better than the terrible rendering from before.

I mean, we could argue for ages about the perfect color(s), but at least, seing the previous rendering, I agree that there is no regression at all.

All the best!