Skip to content

Treat an invalid error on credential removal as a missing entry on Windows#15562

Closed
zanieb wants to merge 1 commit intomainfrom
zb/missing-invalid
Closed

Treat an invalid error on credential removal as a missing entry on Windows#15562
zanieb wants to merge 1 commit intomainfrom
zb/missing-invalid

Conversation

@zanieb
Copy link
Member

@zanieb zanieb commented Aug 27, 2025 •
edited
Loading

As in #15552 — I don't know what the cause of this is. Maybe we should be retrying on this instead?

@zanieb zanieb added the internal A refactor or improvement that is not user-facing label Aug 27, 2025
@zanieb zanieb temporarily deployed to uv-test-registries August 27, 2025 19:39 — with GitHub Actions Inactive
@zanieb zanieb force-pushed the zb/missing-invalid branch from 97fc0d1 to 396dc06 Compare August 27, 2025 19:46
@zanieb zanieb temporarily deployed to uv-test-registries August 27, 2025 19:49 — with GitHub Actions Inactive
@zanieb zanieb mentioned this pull request Aug 27, 2025
Merged
@zanieb zanieb closed this Aug 27, 2025
zanieb added a commit that referenced this pull request Aug 27, 2025
@zanieb
Ensure we get the last error from Windows on the same thread (#15564)
17a86d8 
Reverts #15552
Closes #15562
Closes #15558

The `GetLastError` calls must be on the same thread, or we can pull the
wrong last error!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

internal A refactor or improvement that is not user-facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@zanieb