Ensure we get the last error from Windows on the same thread#15564
Merged
Ensure we get the last error from Windows on the same thread#15564
Conversation
26eb8cb to
a2ade69
Compare
zanieb
commented
Aug 27, 2025
| }) | ||
| .await? | ||
| { | ||
| 0 => Err(decode_error()), |
Member
Author
There was a problem hiding this comment.
Notice here we called decode_error which invokes GetLastError outside of the credential delete thread
Member
Author
There was a problem hiding this comment.
cc @oconnor663 just so you're aware of the gotcha in the future :)
a2ade69 to
8581db2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #15552
Closes #15562
Closes #15558
The
GetLastErrorcalls must be on the same thread, or we can pull the wrong last error!