Skip to content

Add preview warnings to native-keyring usage#15555

Merged
zanieb merged 1 commit intofeature/authfrom
zb/uv-auth-iii
Aug 28, 2025
Merged

Add preview warnings to native-keyring usage#15555
zanieb merged 1 commit intofeature/authfrom
zb/uv-auth-iii

Conversation

@zanieb
Copy link
Member

@zanieb zanieb commented Aug 27, 2025

The refactor here was all done by Claude Code.

@zanieb zanieb temporarily deployed to uv-test-registries August 27, 2025 17:33 — with GitHub Actions Inactive
@zanieb zanieb temporarily deployed to uv-test-registries August 27, 2025 17:36 — with GitHub Actions Inactive
@zanieb zanieb temporarily deployed to uv-test-publish August 27, 2025 17:37 — with GitHub Actions Inactive
@zanieb zanieb temporarily deployed to uv-test-registries August 27, 2025 17:46 — with GitHub Actions Inactive
@zanieb zanieb temporarily deployed to uv-test-publish August 27, 2025 17:47 — with GitHub Actions Inactive
@zanieb zanieb temporarily deployed to uv-test-registries August 27, 2025 18:02 — with GitHub Actions Inactive
@zanieb zanieb temporarily deployed to uv-test-publish August 27, 2025 18:02 — with GitHub Actions Inactive
@zanieb
Copy link
Member Author

zanieb commented Aug 27, 2025

I believe the CI failure here will be resolved by #15564

@charliermarsh
Copy link
Member

Not specific to this PR, but I wonder if we should use some kind of singleton so that we don't have to wire preview everywhere. E.g., a global mutable preview thing that we initialize at the start of the program...

@zanieb
Copy link
Member Author

zanieb commented Aug 28, 2025

Not specific to this PR, but I wonder if we should use some kind of singleton so that we don't have to wire preview everywhere. E.g., a global mutable preview thing that we initialize at the start of the program...

Yeah, we've talked about it. Then you lose some visibility into which code paths have preview behaviors, but... could definitely be worth it.

@zanieb zanieb marked this pull request as ready for review August 28, 2025 13:18
Base automatically changed from zb/uv-auth-ii to feature/auth August 28, 2025 13:34
@konstin
Copy link
Member

konstin commented Aug 28, 2025

If we merge #15548 first, we can remove most of the non-test changes, the preview feature gets passed in the base client builder once before the cli command match. For the test usages, we can set the default preview mode in BaseClientBuilder::default().

@zanieb zanieb temporarily deployed to uv-test-publish August 28, 2025 14:52 — with GitHub Actions Inactive
@zanieb zanieb merged commit d915406 into feature/auth Aug 28, 2025
241 of 242 checks passed
@zanieb zanieb deleted the zb/uv-auth-iii branch August 28, 2025 15:30
@zanieb
Copy link
Member Author

zanieb commented Aug 28, 2025

(Just going into a feature branch, can drop a bunch of it as you said if your PR lands)

zanieb added a commit that referenced this pull request Aug 29, 2025
The refactor here was all done by Claude Code.
zanieb added a commit that referenced this pull request Aug 30, 2025
The refactor here was all done by Claude Code.
zanieb added a commit that referenced this pull request Aug 31, 2025
The refactor here was all done by Claude Code.
zanieb added a commit that referenced this pull request Sep 2, 2025
The refactor here was all done by Claude Code.
@zanieb zanieb mentioned this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants