Skip to content

Add a release-gate step to the release workflow#859

Merged
eifinger merged 1 commit intomainfrom
zb/release-gate
Apr 16, 2026
Merged

Add a release-gate step to the release workflow#859
eifinger merged 1 commit intomainfrom
zb/release-gate

Conversation

@zanieb
Copy link
Copy Markdown
Member

@zanieb zanieb commented Apr 16, 2026

No description provided.

Comment on lines +50 to +59
release-gate:
# N.B. This name should not change, it is used for downstream checks.
name: release-gate
needs:
- validate-release
runs-on: ubuntu-latest
environment:
name: release-gate
steps:
- run: echo "Release approved"
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step is when manual approval occurs, allowing the subsequent steps to be automatically approved by a GitHub App to work around GitHub's approve-per-job semantics.

See https://github.com/open-security-tools/ost-environment-gate

Comment on lines +61 to +70
create-deployment:
name: create-deployment
needs:
- validate-release
- release-gate
runs-on: ubuntu-latest
environment:
name: release
steps:
- run: echo "Release deployment created"
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a no-op job which ensures we have a successful deployment to the release environment for this commit.

needs:
- validate-release
- release-gate
- create-deployment
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that create-deployment has run, this job can create a tag

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't actually need the release environment, because we don't need secrets to release

@zanieb zanieb marked this pull request as ready for review April 16, 2026 18:53
@zanieb zanieb requested a review from eifinger as a code owner April 16, 2026 18:53
Copy link
Copy Markdown
Collaborator

@eifinger eifinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow...
lets try this.

@eifinger eifinger added the ci Pull requests that change the CI workflows label Apr 16, 2026
@eifinger eifinger merged commit 717d6ab into main Apr 16, 2026
90 checks passed
@eifinger eifinger deleted the zb/release-gate branch April 16, 2026 18:57
luketainton pushed a commit to luketainton/repos_pypilot that referenced this pull request Apr 17, 2026
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) | action | minor | `v8.0.0` → `v8.1.0` |

---

### Release Notes

<details>
<summary>astral-sh/setup-uv (astral-sh/setup-uv)</summary>

### [`v8.1.0`](https://github.com/astral-sh/setup-uv/releases/tag/v8.1.0): 🌈 New input `no-project`

[Compare Source](astral-sh/setup-uv@v8.0.0...v8.1.0)

#### Changes

This add the a new boolean input `no-project`.
It only makes sense to use in combination with `activate-environment: true` and will append `--no project` to the `uv venv` call. This is for example useful [if you have a pyproject.toml file with parts unparseable by uv](astral-sh/setup-uv#854)

#### 🚀 Enhancements

- Add input no-project in combination with activate-environment [@&#8203;eifinger](https://github.com/eifinger) ([#&#8203;856](astral-sh/setup-uv#856))

#### 🧰 Maintenance

- fix: grant contents:write to validate-release job [@&#8203;eifinger](https://github.com/eifinger) ([#&#8203;860](astral-sh/setup-uv#860))
- Add a release-gate step to the release workflow [@&#8203;zanieb](https://github.com/zanieb) ([#&#8203;859](astral-sh/setup-uv#859))
- Draft commitish releases [@&#8203;eifinger](https://github.com/eifinger) ([#&#8203;858](astral-sh/setup-uv#858))
- Add action-types.yml to instructions [@&#8203;eifinger](https://github.com/eifinger) ([#&#8203;857](astral-sh/setup-uv#857))
- chore: update known checksums for 0.11.7 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;853](astral-sh/setup-uv#853))
- Refactor version resolving [@&#8203;eifinger](https://github.com/eifinger) ([#&#8203;852](astral-sh/setup-uv#852))
- chore: update known checksums for 0.11.6 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;850](astral-sh/setup-uv#850))
- chore: update known checksums for 0.11.5 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;845](astral-sh/setup-uv#845))
- chore: update known checksums for 0.11.4 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;843](astral-sh/setup-uv#843))
- Add a release workflow [@&#8203;zanieb](https://github.com/zanieb) ([#&#8203;839](astral-sh/setup-uv#839))
- chore: update known checksums for 0.11.3 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;836](astral-sh/setup-uv#836))

#### 📚 Documentation

- Update ignore-nothing-to-cache documentation [@&#8203;eifinger](https://github.com/eifinger) ([#&#8203;833](astral-sh/setup-uv#833))
- Pin setup-uv docs to v8 [@&#8203;eifinger](https://github.com/eifinger) ([#&#8203;829](astral-sh/setup-uv#829))

#### ⬆️ Dependency updates

- chore(deps): bump release-drafter/release-drafter from 7.1.1 to 7.2.0 @&#8203;[dependabot\[bot\]](https://github.com/apps/dependabot) ([#&#8203;855](astral-sh/setup-uv#855))

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMjYuMCIsInVwZGF0ZWRJblZlciI6IjQzLjEyNi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==-->

Reviewed-on: https://git.tainton.uk/repos/pypilot/pulls/436
Co-authored-by: renovate[bot] <renovate-bot@git.tainton.uk>
Co-committed-by: renovate[bot] <renovate-bot@git.tainton.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Pull requests that change the CI workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants