[`pylint`] Implement `unnecessary-dunder-call` (`C2801`) by diceroll123 · Pull Request #9166 · astral-sh/ruff

diceroll123 · 2023-12-16T22:46:19Z

Summary

Implements C2801/unnecessary-dunder-calls

There are more that this could cover, but the implementations get a little less straightforward and ugly. Might come back to it in a future PR, or someone else can!

See: #970

Test Plan

cargo test

github-actions · 2023-12-16T23:20:19Z

`ruff-ecosystem` results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+491 -0 violations, +0 -0 fixes in 12 projects; 29 projects unchanged)

DisnakeDev/disnake (+17 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --preview

+ disnake/activity.py:479:20: PLC2801 [*] Unnecessary dunder call to `__eq__`. Use `==` operator.
+ disnake/activity.py:591:20: PLC2801 [*] Unnecessary dunder call to `__eq__`. Use `==` operator.
+ disnake/activity.py:695:20: PLC2801 [*] Unnecessary dunder call to `__eq__`. Use `==` operator.
+ disnake/activity.py:870:20: PLC2801 [*] Unnecessary dunder call to `__eq__`. Use `==` operator.
+ disnake/colour.py:68:20: PLC2801 [*] Unnecessary dunder call to `__eq__`. Use `==` operator.
+ disnake/context_managers.py:60:16: PLC2801 Unnecessary dunder call to `__enter__`
+ disnake/emoji.py:128:20: PLC2801 [*] Unnecessary dunder call to `__eq__`. Use `==` operator.
+ disnake/ext/commands/params.py:1348:20: PLC2801 Unnecessary dunder call to `__get__`. Use `get` method.
+ disnake/flags.py:153:20: PLC2801 [*] Unnecessary dunder call to `__eq__`. Use `==` operator.
+ disnake/member.py:359:20: PLC2801 [*] Unnecessary dunder call to `__eq__`. Use `==` operator.
... 7 additional changes omitted for project

aiven/aiven-client (+3 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --preview

+ aiven/client/argx.py:189:9: PLC2801 Unnecessary dunder call to `__init__`. Instantiate class directly.
+ aiven/client/cli.py:141:9: PLC2801 Unnecessary dunder call to `__init__`. Instantiate class directly.
+ aiven/client/client.py:34:9: PLC2801 Unnecessary dunder call to `__init__`. Instantiate class directly.

apache/airflow (+130 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --preview --select ALL

+ airflow/configuration.py:1887:9: PLC2801 Unnecessary dunder call to `__init__`. Instantiate class directly.
+ airflow/configuration.py:1962:36: PLC2801 Unnecessary dunder call to `__fspath__`. Use `os.fspath` function.
+ airflow/configuration.py:1966:62: PLC2801 Unnecessary dunder call to `__fspath__`. Use `os.fspath` function.
+ airflow/configuration.py:1974:41: PLC2801 Unnecessary dunder call to `__fspath__`. Use `os.fspath` function.
+ airflow/configuration.py:1979:65: PLC2801 Unnecessary dunder call to `__fspath__`. Use `os.fspath` function.
+ airflow/configuration.py:1997:39: PLC2801 Unnecessary dunder call to `__fspath__`. Use `os.fspath` function.
+ airflow/models/baseoperator.py:192:16: PLC2801 Unnecessary dunder call to `__get__`. Use `get` method.
+ airflow/models/taskmixin.py:109:9: PLC2801 [*] Unnecessary dunder call to `__lshift__`. Use `<<` operator.
+ airflow/models/taskmixin.py:114:9: PLC2801 [*] Unnecessary dunder call to `__rshift__`. Use `>>` operator.
+ airflow/models/xcom.py:724:21: PLC2801 Unnecessary dunder call to `__enter__`
+ airflow/providers/elasticsearch/log/es_response.py:57:20: PLC2801 Unnecessary dunder call to `__getitem__`. Access item via subscript.
+ airflow/providers/fab/auth_manager/cli_commands/user_command.py:167:44: PLC2801 Unnecessary dunder call to `__getattribute__`. Access attribute directly or use getattr built-in function..
+ airflow/providers/fab/auth_manager/cli_commands/user_command.py:60:66: PLC2801 Unnecessary dunder call to `__getattribute__`. Access attribute directly or use getattr built-in function..
... 117 additional changes omitted for project

aws/aws-sam-cli (+56 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --preview

+ samcli/commands/exceptions.py:28:9: PLC2801 Unnecessary dunder call to `__init__`. Instantiate class directly.
+ samcli/commands/exceptions.py:47:9: PLC2801 Unnecessary dunder call to `__init__`. Instantiate class directly.
+ samcli/commands/local/lib/debug_context.py:31:16: PLC2801 [*] Unnecessary dunder call to `__bool__`. Use `bool()` builtin.
+ samcli/hook_packages/terraform/hooks/prepare/exceptions.py:19:9: PLC2801 Unnecessary dunder call to `__init__`. Instantiate class directly.
+ samcli/hook_packages/terraform/hooks/prepare/exceptions.py:34:9: PLC2801 Unnecessary dunder call to `__init__`. Instantiate class directly.
+ samcli/hook_packages/terraform/hooks/prepare/exceptions.py:392:9: PLC2801 Unnecessary dunder call to `__init__`. Instantiate class directly.
+ samcli/hook_packages/terraform/hooks/prepare/exceptions.py:51:9: PLC2801 Unnecessary dunder call to `__init__`. Instantiate class directly.
+ samcli/hook_packages/terraform/hooks/prepare/exceptions.py:74:9: PLC2801 Unnecessary dunder call to `__init__`. Instantiate class directly.
+ samcli/lib/cookiecutter/exceptions.py:9:9: PLC2801 Unnecessary dunder call to `__init__`. Instantiate class directly.
+ samcli/lib/docker/log_streamer.py:20:9: PLC2801 Unnecessary dunder call to `__init__`. Instantiate class directly.
... 46 additional changes omitted for project

bokeh/bokeh (+12 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --preview --select ALL

+ src/bokeh/core/property/descriptors.py:394:16: PLC2801 Unnecessary dunder call to `__get__`. Use `get` method.
+ src/bokeh/core/property/descriptors.py:444:21: PLC2801 Unnecessary dunder call to `__get__`. Use `get` method.
+ src/bokeh/core/property/descriptors.py:652:17: PLC2801 Unnecessary dunder call to `__get__`. Use `get` method.
+ src/bokeh/core/property/descriptors.py:944:17: PLC2801 Unnecessary dunder call to `__set__`. Use subscript assignment.
+ src/bokeh/core/property/wrappers.py:476:17: PLC2801 Unnecessary dunder call to `__setitem__`. Use subscript assignment.
+ src/bokeh/embed/util.py:276:16: PLC2801 Unnecessary dunder call to `__getitem__`. Access item via subscript.
+ src/bokeh/models/plots.py:909:20: PLC2801 Unnecessary dunder call to `__getattribute__`. Access attribute directly or use getattr built-in function..
+ tests/unit/bokeh/core/property/test_descriptors.py:105:13: PLC2801 Unnecessary dunder call to `__set__`. Use subscript assignment.
+ tests/unit/bokeh/core/property/test_descriptors.py:98:13: PLC2801 Unnecessary dunder call to `__get__`. Use `get` method.
+ tests/unit/bokeh/core/property/test_wrappers__property.py:550:12: PLC2801 Unnecessary dunder call to `__copy__`. Use `copy.copy()` function.
... 2 additional changes omitted for project

freedomofpress/securedrop (+20 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --preview

+ journalist_gui/journalist_gui/SecureDropUpdater.py:125:9: PLC2801 Unnecessary dunder call to `__init__`. Instantiate class directly.
+ journalist_gui/journalist_gui/SecureDropUpdater.py:49:9: PLC2801 Unnecessary dunder call to `__init__`. Instantiate class directly.
+ journalist_gui/journalist_gui/SecureDropUpdater.py:89:9: PLC2801 Unnecessary dunder call to `__init__`. Instantiate class directly.
+ securedrop/journalist_app/sessions.py:31:9: PLC2801 Unnecessary dunder call to `__init__`. Instantiate class directly.
+ securedrop/pretty_bad_protocol/_meta.py:677:54: PLC2801 [*] Unnecessary dunder call to `__repr__`. Use `repr()` builtin.
+ securedrop/pretty_bad_protocol/_meta.py:688:59: PLC2801 [*] Unnecessary dunder call to `__repr__`. Use `repr()` builtin.
+ securedrop/pretty_bad_protocol/_parsers.py:1774:9: PLC2801 Unnecessary dunder call to `__init__`. Instantiate class directly.
+ securedrop/pretty_bad_protocol/_util.py:364:11: PLC2801 [*] Unnecessary dunder call to `__str__`. Use `str()` builtin.
+ securedrop/tests/migrations/migration_a9fe328b053a.py:50:9: PLC2801 Unnecessary dunder call to `__init__`. Instantiate class directly.
+ securedrop/tests/migrations/migration_a9fe328b053a.py:72:9: PLC2801 Unnecessary dunder call to `__init__`. Instantiate class directly.
... 10 additional changes omitted for project

fronzbot/blinkpy (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --preview

+ blinkpy/sync_module.py:759:16: PLC2801 [*] Unnecessary dunder call to `__repr__`. Use `repr()` builtin.

ibis-project/ibis (+21 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --preview

+ ibis/common/bases.py:198:13: PLC2801 Unnecessary dunder call to `__setattr__`. Mutate attribute directly or use setattr built-in function..
+ ibis/common/bases.py:212:13: PLC2801 Unnecessary dunder call to `__setattr__`. Mutate attribute directly or use setattr built-in function..
+ ibis/common/bases.py:239:13: PLC2801 Unnecessary dunder call to `__setattr__`. Mutate attribute directly or use setattr built-in function..
+ ibis/common/bases.py:241:9: PLC2801 Unnecessary dunder call to `__setattr__`. Mutate attribute directly or use setattr built-in function..
+ ibis/common/bases.py:245:13: PLC2801 Unnecessary dunder call to `__setattr__`. Mutate attribute directly or use setattr built-in function..
+ ibis/common/bases.py:247:9: PLC2801 Unnecessary dunder call to `__setattr__`. Mutate attribute directly or use setattr built-in function..
+ ibis/common/caching.py:39:9: PLC2801 Unnecessary dunder call to `__setattr__`. Mutate attribute directly or use setattr built-in function..
+ ibis/common/collections.py:229:43: PLC2801 [*] Unnecessary dunder call to `__ge__`. Use `>=` operator.
+ ibis/common/collections.py:240:43: PLC2801 [*] Unnecessary dunder call to `__le__`. Use `<=` operator.
+ ibis/common/collections.py:295:9: PLC2801 Unnecessary dunder call to `__setattr__`. Mutate attribute directly or use setattr built-in function..
... 11 additional changes omitted for project

milvus-io/pymilvus (+13 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --preview

+ pymilvus/client/abstract.py:179:16: PLC2801 [*] Unnecessary dunder call to `__str__`. Use `str()` builtin.
+ pymilvus/client/abstract.py:282:16: PLC2801 [*] Unnecessary dunder call to `__str__`. Use `str()` builtin.
+ pymilvus/client/abstract.py:360:16: PLC2801 [*] Unnecessary dunder call to `__str__`. Use `str()` builtin.
+ pymilvus/client/abstract.py:627:35: PLC2801 [*] Unnecessary dunder call to `__len__`. Use `len()` builtin.
+ pymilvus/client/abstract.py:627:69: PLC2801 [*] Unnecessary dunder call to `__len__`. Use `len()` builtin.
+ pymilvus/client/abstract.py:632:20: PLC2801 [*] Unnecessary dunder call to `__len__`. Use `len()` builtin.
+ pymilvus/client/abstract.py:639:30: PLC2801 [*] Unnecessary dunder call to `__len__`. Use `len()` builtin.
+ pymilvus/client/abstract.py:641:20: PLC2801 Unnecessary dunder call to `__getitem__`. Access item via subscript.
+ pymilvus/client/abstract.py:648:34: PLC2801 Unnecessary dunder call to `__getitem__`. Access item via subscript.
+ pymilvus/client/prepare.py:1177:24: PLC2801 [*] Unnecessary dunder call to `__str__`. Use `str()` builtin.
... 3 additional changes omitted for project

... Truncated remaining completed project reports due to GitHub comment length restrictions

Changes by rule (2 rules affected)

code	total	+ violation	- violation	+ fix	- fix
PLC2801	490	490	0	0	0
E711	1	1	0	0	0

charliermarsh

Reviewing now...

## Summary Fix the message for `__aenter__ ` in PLC2801 (introduced in #9166) There is no `aenter` builtin in Python, so the current message is misleading. I take the message from original lint https://github.com/pylint-dev/pylint/blob/main/pylint/constants.py#L211 P.S. I think here should be more accurate synchronization with original lint (e.g. the current implementation will not lint `__enter__` on my first sight), but it is out-of-scope of this change.  ## Test Plan

diceroll123 force-pushed the add-C2801 branch 3 times, most recently from 42ad4f3 to d8d25f7 Compare December 16, 2023 23:01

C2801

17798cf

diceroll123 force-pushed the add-C2801 branch from d8d25f7 to 17798cf Compare December 16, 2023 23:07

diceroll123 added 2 commits December 16, 2023 18:24

skip __init__

4a6f188

skip common dunders

f112dbf

diceroll123 marked this pull request as draft December 16, 2023 23:50

diceroll123 force-pushed the add-C2801 branch 3 times, most recently from 504f0cf to 2af5c87 Compare December 17, 2023 17:42

bunch of tweaks

90ff72b

diceroll123 force-pushed the add-C2801 branch from 2af5c87 to 90ff72b Compare December 17, 2023 18:13

diceroll123 marked this pull request as ready for review December 19, 2023 17:38

Merge branch 'main' into add-C2801

1e44d39

charliermarsh reviewed Jan 3, 2024

View reviewed changes

Use structs

230b3de

charliermarsh force-pushed the add-C2801 branch from 40136bd to 230b3de Compare January 3, 2024 18:02

charliermarsh approved these changes Jan 3, 2024

View reviewed changes

charliermarsh added rule Implementing or modifying a lint rule preview Related to preview mode features labels Jan 3, 2024

charliermarsh changed the title ~~[pylint] - implement C2801/unnecessary-dunder-calls~~ [pylint] Implement unnecessary-dunder-calls (C2801) Jan 3, 2024

charliermarsh changed the title ~~[pylint] Implement unnecessary-dunder-calls (C2801)~~ [pylint] Implement unnecessary-dunder-call (C2801) Jan 3, 2024

charliermarsh enabled auto-merge (squash) January 3, 2024 18:04

charliermarsh merged commit e3ad163 into astral-sh:main Jan 3, 2024

trag1c mentioned this pull request Jan 11, 2024

Add PR title guidelines to CONTRIBUTING.md #9470

Closed

Porkepix mentioned this pull request Jan 12, 2024

ruff 0.1.12 Homebrew/homebrew-core#159717

Merged

alex-700 mentioned this pull request Jan 12, 2024

Fix message for __aenter__ in PLC2801 #9492

Merged

dimbleby mentioned this pull request Jan 19, 2024

false positive on PLC2801 "unnecessary dunder... for __setattr__" #9584

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[`pylint`] Implement `unnecessary-dunder-call` (`C2801`)#9166

[`pylint`] Implement `unnecessary-dunder-call` (`C2801`)#9166
charliermarsh merged 6 commits intoastral-sh:mainfrom
diceroll123:add-C2801

diceroll123 commented Dec 16, 2023

Uh oh!

github-actions bot commented Dec 16, 2023 •

edited

Loading

Uh oh!

charliermarsh left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

diceroll123 commented Dec 16, 2023

Summary

Test Plan

Uh oh!

github-actions bot commented Dec 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ruff-ecosystem results

Linter (stable)

Linter (preview)

Uh oh!

charliermarsh left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Dec 16, 2023 •

edited

Loading

`ruff-ecosystem` results