Fix message for __aenter__ in PLC2801#9492
Merged
charliermarsh merged 1 commit intoastral-sh:mainfrom Jan 12, 2024
Merged
Conversation
Contributor
|
Member
|
Thanks! |
Contributor
|
Woops! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the message for
__aenter__in PLC2801 (introduced in #9166)There is no
aenterbuiltin in Python, so the current message is misleading.I take the message from original lint https://github.com/pylint-dev/pylint/blob/main/pylint/constants.py#L211
P.S. I think here should be more accurate synchronization with original lint (e.g. the current implementation will not lint
__enter__on my first sight), but it is out-of-scope of this change.Test Plan