Skip to content

Avoid B015,B018 for last expression in a cell#8815

Merged
dhruvmanila merged 5 commits intomainfrom
dhruv/notebook-b015-b018
Nov 22, 2023
Merged

Avoid B015,B018 for last expression in a cell#8815
dhruvmanila merged 5 commits intomainfrom
dhruv/notebook-b015-b018

Conversation

@dhruvmanila
Copy link
Copy Markdown
Member

Summary

This PR updates B015 and B018 to ignore last top-level expressions in each
cell of a Jupyter Notebook.

Part of #8669

Test Plan

Add test cases for both rules and update the snapshots.

@dhruvmanila
Copy link
Copy Markdown
Member Author

@dhruvmanila dhruvmanila added the rule Implementing or modifying a lint rule label Nov 21, 2023
Copy link
Copy Markdown
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Base automatically changed from dhruv/cell-offsets to main November 22, 2023 15:27
@dhruvmanila dhruvmanila enabled auto-merge (squash) November 22, 2023 15:28
@dhruvmanila dhruvmanila merged commit 5b726f7 into main Nov 22, 2023
@dhruvmanila dhruvmanila deleted the dhruv/notebook-b015-b018 branch November 22, 2023 15:33
@github-actions
Copy link
Copy Markdown
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rule Implementing or modifying a lint rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants