Skip to content

Add CellOffsets abstraction#8814

Merged
dhruvmanila merged 3 commits intomainfrom
dhruv/cell-offsets
Nov 22, 2023
Merged

Add CellOffsets abstraction#8814
dhruvmanila merged 3 commits intomainfrom
dhruv/cell-offsets

Conversation

@dhruvmanila
Copy link
Copy Markdown
Member

Refactor Notebook::cell_offsets to use an abstract struct for storing the cell
offsets. This will allow us to add useful methods on it.

@dhruvmanila
Copy link
Copy Markdown
Member Author

@dhruvmanila dhruvmanila added the internal An internal refactor or improvement label Nov 21, 2023
Copy link
Copy Markdown
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, great idea.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 21, 2023

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Base automatically changed from dhruv/cell to main November 22, 2023 15:21
@dhruvmanila dhruvmanila enabled auto-merge (squash) November 22, 2023 15:22
@dhruvmanila dhruvmanila merged commit 727e389 into main Nov 22, 2023
@dhruvmanila dhruvmanila deleted the dhruv/cell-offsets branch November 22, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants