Formatter parentheses support for IpyEscapeCommand#8207
Merged
dhruvmanila merged 2 commits intomainfrom Oct 25, 2023
Merged
Conversation
Member
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
c8feeda to
6012c5d
Compare
b0a7908 to
15984dc
Compare
MichaReiser
approved these changes
Oct 25, 2023
Member
MichaReiser
left a comment
There was a problem hiding this comment.
Looks good to me. Can we add an E2E test (CLI test) in the parent PR that tests ruff format with a notebook that contains ipython commands?
15984dc to
7dd63e1
Compare
Member
Author
Do you mean in this PR? I've added it. |
Contributor
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
konstin
approved these changes
Oct 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR removes the
todo!()aroundIpyEscapeCommandin the formatter.The
NeedsParenthesestrait needs to be implemented which always returnNever. The reason being that if an escape command is parenthesized, then that's not parsed as an escape command. IOW, the parentheses shouldn't be present around an escape command.In the similar way, the
CanSkipOptionalParenthesesVisitorwill skip this node.Test Plan
Updated the
unformatted.ipynbfixture with new cells containing IPython escape commands and the corresponding snapshot was verified. Also, tested it out in a few open source repositories containing notebooks (openai/openai-cookbook,huggingface/notebooks).New cells in
unformatted.ipynbCell 2
Cell 3
Cell 4
fixes: #8204