Use source type to determine parser mode for formatting#8205
Merged
dhruvmanila merged 1 commit intomainfrom Oct 25, 2023
Merged
Use source type to determine parser mode for formatting#8205dhruvmanila merged 1 commit intomainfrom
dhruvmanila merged 1 commit intomainfrom
Conversation
Member
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
c8feeda to
6012c5d
Compare
Contributor
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
konstin
approved these changes
Oct 25, 2023
Member
konstin
left a comment
There was a problem hiding this comment.
Nit: I'd move the fixes: #8204 to the PR up the stack so it's easier to trace later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the bug where if a Notebook contained IPython syntax, then the format command would fail. This was because the correct mode was not being used while parsing through the formatter code path.
Test Plan
This PR isn't the only requirement for Notebook formatting to start working with IPython escape commands. The following PR in the stack is required as well.