Document lint.preview and format.preview#8032
Merged
MichaReiser merged 6 commits intomainfrom Oct 18, 2023
Merged
Conversation
This was referenced Oct 18, 2023
Merged
Member
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Oct 18, 2023
MichaReiser
commented
Oct 18, 2023
0817df9 to
463165c
Compare
zanieb
reviewed
Oct 18, 2023
zanieb
reviewed
Oct 18, 2023
Add a new `lint.preview` option that configures the preview mode for the linter only.
Co-authored-by: Zanie Blue <contact@zanie.dev>
Co-authored-by: Zanie Blue <contact@zanie.dev>
bbeabda to
61c6462
Compare
zanieb
reviewed
Oct 18, 2023
zanieb
approved these changes
Oct 18, 2023
konstin
approved these changes
Oct 18, 2023
Member
konstin
left a comment
There was a problem hiding this comment.
Do we want to say that the formatter preview mode aims to mirror black preview mode?
Co-authored-by: Zanie Blue <contact@zanie.dev>
Member
Author
I would prefer a dedicated section that lists all preview style changes with an example, similar to what black has. |
This was referenced Oct 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The documentation for #8002. I separated it to a separate PR to unblock landing the code changes but still get the documentation reviewed.