Closed
Conversation
This was referenced Oct 17, 2023
Merged
Member
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
crates/ruff_workspace/src/options.rs
Outdated
| line-length = 120 | ||
| "# | ||
| )] | ||
| #[serde(alias = "line-width", alias = "max-line-length")] |
Member
There was a problem hiding this comment.
Is max-line-length for convenience, or something we once supported?
Member
Author
There was a problem hiding this comment.
That was a test-only change that I accidentally committed... I reverted the change
a88b7c6 to
9f9d515
Compare
366d2be to
a583805
Compare
9f9d515 to
408b34e
Compare
a583805 to
f1b00ca
Compare
Signed-off-by: Micha Reiser <micha@reiser.io>
408b34e to
6ca7407
Compare
Contributor
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
Member
Author
|
schemars doesn't support aliases. Closing for now |
This was referenced Oct 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR adds support for serde's
#[serde(alias="name")]field-attribute to our options code generator. Simplifying supporting aliases for the same setting.I'm unsure if we should land this change. I may not end up using it for
line-lengthbecause I think it's better to actually deprecate these options rather than supporting both (by adding support for Rust'sdeprecatedattribute). However, it is a neat feature and it already works.Test Plan
I changed
line-lengthtoAnd generated the options markdown