Skip to content

Format PatternMatchValue#6608

Closed
evanrittenhouse wants to merge 1 commit intoastral-sh:mainfrom
evanrittenhouse:evanrittenhouse/6555
Closed

Format PatternMatchValue#6608
evanrittenhouse wants to merge 1 commit intoastral-sh:mainfrom
evanrittenhouse:evanrittenhouse/6555

Conversation

@evanrittenhouse
Copy link
Contributor

@evanrittenhouse evanrittenhouse commented Aug 16, 2023

Summary

Test Plan

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2023 •
edited
Loading

PR Check Results

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      4.0±0.23ms    10.1 MB/sec    1.04      4.2±0.16ms     9.8 MB/sec
formatter/numpy/ctypeslib.py               1.00   815.7±37.53µs    20.4 MB/sec    1.07   870.0±19.24µs    19.1 MB/sec
formatter/numpy/globals.py                 1.00     80.9±4.65µs    36.5 MB/sec    1.08     87.4±3.42µs    33.8 MB/sec
formatter/pydantic/types.py                1.00  1562.0±63.05µs    16.3 MB/sec    1.08  1684.9±80.34µs    15.1 MB/sec
linter/all-rules/large/dataset.py          1.00     12.5±0.36ms     3.3 MB/sec    1.06     13.2±0.46ms     3.1 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.3±0.06ms     5.1 MB/sec    1.05      3.4±0.10ms     4.8 MB/sec
linter/all-rules/numpy/globals.py          1.00   473.9±10.18µs     6.2 MB/sec    1.05   498.0±16.29µs     5.9 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.4±0.19ms     4.0 MB/sec    1.05      6.7±0.19ms     3.8 MB/sec
linter/default-rules/large/dataset.py      1.00      6.5±0.18ms     6.3 MB/sec    1.08      7.0±0.17ms     5.8 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1489.6±79.59µs    11.2 MB/sec    1.02  1521.4±40.34µs    10.9 MB/sec
linter/default-rules/numpy/globals.py      1.00    178.4±7.09µs    16.5 MB/sec    1.04    185.4±5.94µs    15.9 MB/sec
linter/default-rules/pydantic/types.py     1.00      2.9±0.06ms     8.9 MB/sec    1.08      3.1±0.07ms     8.2 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      4.8±0.27ms     8.6 MB/sec    1.00      4.7±0.21ms     8.6 MB/sec
formatter/numpy/ctypeslib.py               1.00  963.0±145.09µs    17.3 MB/sec    1.01   970.4±46.00µs    17.2 MB/sec
formatter/numpy/globals.py                 1.00     95.6±5.79µs    30.9 MB/sec    1.00     95.8±6.19µs    30.8 MB/sec
formatter/pydantic/types.py                1.00  1865.3±89.05µs    13.7 MB/sec    1.01  1892.5±74.19µs    13.5 MB/sec
linter/all-rules/large/dataset.py          1.00     15.6±0.61ms     2.6 MB/sec    1.02     15.9±0.52ms     2.6 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.01      4.4±0.10ms     3.8 MB/sec    1.00      4.3±0.15ms     3.9 MB/sec
linter/all-rules/numpy/globals.py          1.00   546.1±26.14µs     5.4 MB/sec    1.01   549.8±21.83µs     5.4 MB/sec
linter/all-rules/pydantic/types.py         1.00      8.2±0.35ms     3.1 MB/sec    1.00      8.2±0.27ms     3.1 MB/sec
linter/default-rules/large/dataset.py      1.01      8.7±0.32ms     4.7 MB/sec    1.00      8.6±0.22ms     4.7 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1820.9±75.76µs     9.1 MB/sec    1.00  1822.9±67.13µs     9.1 MB/sec
linter/default-rules/numpy/globals.py      1.02    230.4±8.30µs    12.8 MB/sec    1.00    226.9±8.20µs    13.0 MB/sec
linter/default-rules/pydantic/types.py     1.01      3.8±0.12ms     6.6 MB/sec    1.00      3.8±0.15ms     6.7 MB/sec

@konstin konstin added the formatter Related to the formatter label Aug 21, 2023
@konstin
Copy link
Member

konstin commented Aug 21, 2023

Compiler panic?

Did you run into rust-lang/rust#111513?

@MichaReiser MichaReiser linked an issue Aug 22, 2023 that may be closed by this pull request
Format PatternMatchValue #6555
Closed
@charliermarsh charliermarsh mentioned this pull request Aug 23, 2023
Merged
@charliermarsh
Copy link
Member

charliermarsh commented Aug 23, 2023

I renewed this as #6799 since I'd like to keep working on some related problems around comments and parentheses.

charliermarsh added a commit that referenced this pull request Aug 23, 2023
@charliermarsh
Implement FormatPatternMatchValue (#6799)
71c25e4 
## Summary

This is effectively #6608, but with additional tests.

We aren't properly handling parenthesized patterns, but that needs to be
dealt with separately as it's somewhat involved.

Closes #6555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaReiser MichaReiser Awaiting requested review from MichaReiser MichaReiser will be requested when the pull request is marked ready for review MichaReiser is a code owner

Assignees

No one assigned

Labels

formatter Related to the formatter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Format PatternMatchValue

4 participants

@evanrittenhouse @konstin @charliermarsh @MichaReiser