[ty] Avoid the mandatory "ecosystem-analyzer workflow run cancelled" notification every time you make a PR#23695
Merged
AlexWaygood merged 1 commit intomainfrom Mar 3, 2026
Conversation
The `cancel-in-progress` concurrency setting was unconditionally cancelling previous workflow runs on every push to a PR. For PRs without the `ecosystem-analyzer` label, this generated a "cancelled" notification even though the job would have been immediately skipped anyway. Only cancel in-progress runs when the label is present. https://claude.ai/code/session_01LH6Q6gjrb3aJqhEexrynjk
Member
Author
|
Even if this isn't the cause, I don't see how this PR can do any harm. |
carljm
added a commit
that referenced
this pull request
Mar 3, 2026
* main: [ty] Apply narrowing to walrus values (#23687) [`perflint`] Extend `PERF102` to comprehensions and generators (#23473) [ty] Fix GitHub-annotations mdtest output format (#23694) [ty] Reduce the number of potentially-flaky projects (#23698) [`pydocstyle`] Fix numpy section ordering (`D420`) (#23685) [ty] Move method-related types to a submodule (#23691) [ty] Avoid the mandatory "ecosystem-analyzer workflow run cancelled" notification every time you make a PR (#23695) [ty] Move `Type::subtyping_is_always_reflexive` to `types::relation` (#23692) Update conformance suite commit hash (#23693) [ty] Add mdtest suite for `typing.Concatenate` (#23554) [ty] filter out pre-loop bindings from loop headers (#23536)
AlexWaygood
pushed a commit
that referenced
this pull request
Mar 4, 2026
PR #23695 only made `cancel-in-progress` conditional on the `ecosystem-analyzer` label, but that wasn't sufficient. GitHub Actions concurrency groups with `cancel-in-progress: false` still cancel *pending/queued* runs in the same group — they just don't cancel *in-progress* ones. So every push to any PR still entered the same concurrency group, and queued runs got cancelled, generating notifications. Fix this by making the concurrency group name unique per run (using `github.run_id`) when the `ecosystem-analyzer` label is absent. This way, unlabeled PR runs never share a concurrency group, so no collisions or cancellations occur. When the label is present, runs share a group keyed by PR number so stale runs are properly cancelled. https://claude.ai/code/session_01GNDqAXQ1boZHxv4H1tGQFy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently I get an "ecosystem-analyzer workflow cancelled" notification every time I make a PR, regardless of whether the ecosystem-analyzer label is present on the PR when the PR is initially made. Claude's analysis is:
Which seems plausible?