[ty] Merge SemanticIndexBuilder impl blocks#18135
Merged
AlexWaygood merged 1 commit intomainfrom May 16, 2025
Merged
Conversation
Contributor
|
MichaReiser
approved these changes
May 16, 2025
Glyphack
pushed a commit
to Glyphack/ruff
that referenced
this pull request
May 21, 2025
## Summary just a minor nit followup to astral-sh#18010 -- put all the non-`Visitor` methods of `SemanticIndexBuilder` in the same impl block rather than having multiple impl blocks ## Test Plan `cargo build`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
just a minor nit followup to #18010 -- put all the non-
Visitormethods ofSemanticIndexBuilderin the same impl block rather than having multiple impl blocksTest Plan
cargo build