[ty] Better control flow for boolean expressions that are inside if#18010
Merged
carljm merged 2 commits intoastral-sh:mainfrom May 16, 2025
Merged
Conversation
Contributor
|
6859200 to
adc3f1f
Compare
Contributor
|
Just adding a note that it looks like this fixes astral-sh/ty#139 |
Contributor
It's fantastic that you found a way to make this work, and I'm looking forward to reviewing this! I'll just add another note here that merging this PR is not an immediate priority (anymore) because we recently decided to disable |
carljm
approved these changes
May 16, 2025
Contributor
carljm
left a comment
There was a problem hiding this comment.
This looks really good! Thank you for the contribution. I will push a small commit with a few renaming adjustments and the TODO comments I mentioned inline, and then merge.
crates/ty_python_semantic/resources/mdtest/boolean/short_circuit.md
Outdated
Show resolved
Hide resolved
2ea02c0 to
2b59009
Compare
AlexWaygood
added a commit
that referenced
this pull request
May 16, 2025
## Summary just a minor nit followup to #18010 -- put all the non-`Visitor` methods of `SemanticIndexBuilder` in the same impl block rather than having multiple impl blocks ## Test Plan `cargo build`
carljm
added a commit
that referenced
this pull request
May 17, 2025
…ide if (#18010)" (#18150) This reverts commit 9910ec7. ## Summary This change introduced a serious performance regression. Revert it while we investigate. Fixes astral-sh/ty#431 ## Test Plan Timing on the snippet in astral-sh/ty#431 again shows times similar to before the regression.
Glyphack
pushed a commit
to Glyphack/ruff
that referenced
this pull request
May 21, 2025
…stral-sh#18010) ## Summary With this PR we now detect that x is always defined in `use`: ```py if flag and (x := number): use(x) ``` When outside if, it's still detected as possibly not defined ```py flag and (x := number) # error: [possibly-unresolved-reference] use(x) ``` In order to achieve that, I had to find a way to get access to the flow-snapshots of the boolean expression when analyzing the flow of the if statement. I did it by special casing the visitor of boolean expression to return flow control information, exporting two snapshots - `maybe_short_circuit` and `no_short_circuit`. When indexing boolean expression itself we must assume all possible flows, but when it's inside if statement, we can be smarter than that. ## Test Plan Fixed existing and added new mdtests. I went through some of mypy primer results and they look fine --------- Co-authored-by: Carl Meyer <carl@astral.sh>
Glyphack
pushed a commit
to Glyphack/ruff
that referenced
this pull request
May 21, 2025
## Summary just a minor nit followup to astral-sh#18010 -- put all the non-`Visitor` methods of `SemanticIndexBuilder` in the same impl block rather than having multiple impl blocks ## Test Plan `cargo build`
This was referenced Jun 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With this PR we now detect that x is always defined in
use:When outside if, it's still detected as possibly not defined
In order to achieve that, I had to find a way to get access to the flow-snapshots of the boolean expression when analyzing the flow of the if statement. I did it by special casing the visitor of boolean expression to return flow control information, exporting two snapshots -
might_short_circuitedandnever_short_circuited. When indexing boolean expression itself we must assume all possible flows, but when it's inside if statement, we can be smarter than that.This PR is still kind of draft, but I'd like to get your overall opinion so opening it for review :)
Hope you'll get time to review this before the alpha release :)
Best reviewed by commits
Test Plan
Fixed existing and added new mdtests.
I went through some of mypy primer results and they look fine